Bug 208690 - [Cocoa] Re-enable CFPrefs direct mode
Summary: [Cocoa] Re-enable CFPrefs direct mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-05 20:05 PST by Per Arne Vollan
Modified: 2020-03-11 17:18 PDT (History)
8 users (show)

See Also:

Attachments
Patch (22.08 KB, patch)
2020-03-05 20:22 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (24.17 KB, patch)
2020-03-05 21:12 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (23.30 KB, patch)
2020-03-06 07:43 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (24.58 KB, patch)
2020-03-06 10:39 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (24.81 KB, patch)
2020-03-06 11:29 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (33.91 KB, patch)
2020-03-06 12:10 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (32.65 KB, patch)
2020-03-06 13:49 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (45.46 KB, patch)
2020-03-06 16:56 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (45.47 KB, patch)
2020-03-06 17:53 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (1.91 KB, patch)
2020-03-11 17:15 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (10) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-03-05 20:05:47 PST 
Re-enable CFPrefs direct mode, and address performance and Accessibility issues.
Comment 1 Per Arne Vollan 2020-03-05 20:22:38 PST 
Created attachment 392664 [details]
Patch
Comment 2 Per Arne Vollan 2020-03-05 21:12:01 PST 
Created attachment 392670 [details]
Patch
Comment 3 Per Arne Vollan 2020-03-06 07:43:35 PST 
Created attachment 392720 [details]
Patch
Comment 4 Per Arne Vollan 2020-03-06 10:39:10 PST 
Created attachment 392742 [details]
Patch
Comment 5 Per Arne Vollan 2020-03-06 11:29:41 PST 
Created attachment 392748 [details]
Patch
Comment 6 Per Arne Vollan 2020-03-06 12:10:34 PST 
Created attachment 392751 [details]
Patch
Comment 7 Per Arne Vollan 2020-03-06 13:49:15 PST 
Created attachment 392769 [details]
Patch
Comment 8 Per Arne Vollan 2020-03-06 16:56:48 PST 
Created attachment 392813 [details]
Patch
Comment 9 Brent Fulgham 2020-03-06 17:25:15 PST 
Comment on attachment 392813 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392813&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:342
> +- (void)_grantAccessToPreferenceService WK_API_AVAILABLE(ios(WK_IOS_TBA));

I think this should be macOS(WK_MAC_TBA), too, shouldn't it?
Comment 10 Per Arne Vollan 2020-03-06 17:53:18 PST 
Created attachment 392821 [details]
Patch
Comment 11 Per Arne Vollan 2020-03-06 17:54:06 PST 
(In reply to Brent Fulgham from comment #9)
> Comment on attachment 392813 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=392813&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:342
> > +- (void)_grantAccessToPreferenceService WK_API_AVAILABLE(ios(WK_IOS_TBA));
> 
> I think this should be macOS(WK_MAC_TBA), too, shouldn't it?

Fixed.

Thanks for reviewing!
Comment 12 WebKit Commit Bot 2020-03-06 22:57:28 PST 
The commit-queue encountered the following flaky tests while processing attachment 392821 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 160571 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: dbates@webkit.org)
The commit-queue is continuing to process your patch.
Comment 13 WebKit Commit Bot 2020-03-06 22:58:14 PST 
Comment on attachment 392821 [details]
Patch

Clearing flags on attachment: 392821

Committed r258064: <https://trac.webkit.org/changeset/258064>
Comment 14 Radar WebKit Bug Importer 2020-03-07 07:25:17 PST 
<rdar://problem/60188065>
Comment 15 Per Arne Vollan 2020-03-11 17:15:43 PDT 
Reopening to attach new patch.
Comment 16 Per Arne Vollan 2020-03-11 17:15:44 PDT 
Created attachment 393312 [details]
Patch