Bug 208486 - [WebGL2] Implement texImage2D(TexImageSource) for RGBA/RGBA/UNSIGNED_BYTE ImageElements
Summary: [WebGL2] Implement texImage2D(TexImageSource) for RGBA/RGBA/UNSIGNED_BYTE Ima...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks: 126404
  Show dependency tree / graph
 
Reported: 2020-03-02 16:50 PST by Justin Fan
Modified: 2020-03-24 15:31 PDT (History)
11 users (show)

See Also:

Attachments
Patch (4.60 MB, patch)
2020-03-02 17:04 PST, Justin Fan 		no flags Details | Formatted Diff | Diff
Patch for landing (4.60 MB, patch)
2020-03-03 12:35 PST, Justin Fan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2020-03-02 16:50:35 PST 
[WebGL2] Implement texImage2D(TexImageSource) for RGBA/RGBA/UNSIGNED_BYTE ImageElements
Comment 1 Justin Fan 2020-03-02 17:04:42 PST 
Created attachment 392219 [details]
Patch
Comment 2 Justin Fan 2020-03-03 10:18:27 PST 
Layout test crashes are unrelated to this patch.
Comment 3 Dean Jackson 2020-03-03 12:25:49 PST 
Comment on attachment 392219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392219&action=review

> Source/WebCore/ChangeLog:8
> +        WIP implementation of WebGL 2 texImage2D(TexImageSource).

Maybe say "Partial"?

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3796
> +        // Normal pure SW path.

// Fallback software path.
Comment 4 Justin Fan 2020-03-03 12:35:54 PST 
Created attachment 392311 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2020-03-03 13:26:05 PST 
Comment on attachment 392311 [details]
Patch for landing

Clearing flags on attachment: 392311

Committed r257799: <https://trac.webkit.org/changeset/257799>
Comment 6 WebKit Commit Bot 2020-03-03 13:26:06 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-03-03 13:27:22 PST 
<rdar://problem/60010521>