Bug 208247 - [LFC][BFC][MarginCollapsing] Decouple regular and pre-computed margin collapsing logic
Summary: [LFC][BFC][MarginCollapsing] Decouple regular and pre-computed margin collaps...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-26 09:44 PST by zalan
Modified: 2020-03-01 20:29 PST (History)
7 users (show)

See Also:

Attachments
Patch (15.53 KB, patch)
2020-02-26 09:50 PST, zalan 		no flags Details | Formatted Diff | Diff
Build fix (3.91 KB, patch)
2020-02-27 07:27 PST, zalan 		no flags Details | Formatted Diff | Diff
Non-unified build fix (3.91 KB, patch)
2020-02-27 07:34 PST, zalan 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Non-unified build fix (3.93 KB, patch)
2020-02-27 07:46 PST, zalan 		no flags Details | Formatted Diff | Diff
Non-unified build fix#2 (2.31 KB, patch)
2020-03-01 18:12 PST, zalan 		no flags Details | Formatted Diff | Diff
Non-unified build fix#2 (2.31 KB, patch)
2020-03-01 18:22 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-02-26 09:44:22 PST 
pre-computed is so peculiar it deserves a dedicated file.
Comment 1 Radar WebKit Bug Importer 2020-02-26 09:44:40 PST 
<rdar://problem/59808951>
Comment 2 zalan 2020-02-26 09:50:47 PST 
Created attachment 391752 [details]
Patch
Comment 3 WebKit Commit Bot 2020-02-26 13:31:04 PST 
Comment on attachment 391752 [details]
Patch

Clearing flags on attachment: 391752

Committed r257507: <https://trac.webkit.org/changeset/257507>
Comment 4 WebKit Commit Bot 2020-02-26 13:31:05 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Fujii Hironori 2020-02-26 23:22:47 PST 
Comment on attachment 391752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391752&action=review

> Source/WebCore/layout/blockformatting/PrecomputedBlockMarginCollapse.cpp:66
> +    auto collapsedMarginBefore = computedPositiveAndNegativeMargin(firstChildCollapsedMarginBefore(), previouSiblingCollapsedMarginAfter());

computedPositiveAndNegativeMargin is defined in BlockFormattingContext.cpp. It can't be used in --no-unified-builds.
I don't know how to fix. Please fix it.
Comment 6 zalan 2020-02-27 07:27:56 PST 
Created attachment 391862 [details]
Build fix
Comment 7 zalan 2020-02-27 07:33:41 PST 
fix non-unified builds
Comment 8 zalan 2020-02-27 07:34:50 PST 
Created attachment 391865 [details]
Non-unified build fix
Comment 9 WebKit Commit Bot 2020-02-27 07:43:15 PST 
Comment on attachment 391865 [details]
Non-unified build fix

Rejecting attachment 391865 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 391865, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/13329925
Comment 10 zalan 2020-02-27 07:46:15 PST 
Created attachment 391867 [details]
Non-unified build fix
Comment 11 WebKit Commit Bot 2020-02-27 08:52:12 PST 
The commit-queue encountered the following flaky tests while processing attachment 391867 [details]:

imported/w3c/web-platform-tests/xhr/open-after-stop.window.html bug 208320 (author: cdumez@apple.com)
The commit-queue is continuing to process your patch.
Comment 12 WebKit Commit Bot 2020-02-27 08:52:52 PST 
Comment on attachment 391867 [details]
Non-unified build fix

Clearing flags on attachment: 391867

Committed r257568: <https://trac.webkit.org/changeset/257568>
Comment 13 WebKit Commit Bot 2020-02-27 08:52:54 PST 
All reviewed patches have been landed.  Closing bug.
Comment 14 zalan 2020-03-01 18:12:33 PST 
Created attachment 392112 [details]
Non-unified build fix#2
Comment 15 zalan 2020-03-01 18:21:59 PST 
fix non-unified builds
Comment 16 zalan 2020-03-01 18:22:46 PST 
Created attachment 392113 [details]
Non-unified build fix#2
Comment 17 WebKit Commit Bot 2020-03-01 20:29:14 PST 
Comment on attachment 392113 [details]
Non-unified build fix#2

Clearing flags on attachment: 392113

Committed r257701: <https://trac.webkit.org/changeset/257701>
Comment 18 WebKit Commit Bot 2020-03-01 20:29:16 PST 
All reviewed patches have been landed.  Closing bug.