Bug 208000 - [GTK] Web inspector related tests very slow or timeout in debug mode
Summary: [GTK] Web inspector related tests very slow or timeout in debug mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
: 149916 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-02-20 04:08 PST by Carlos Alberto Lopez Perez
Modified: 2021-03-02 07:52 PST (History)
12 users (show)

See Also:

Attachments
WIP patch (686 bytes, patch)
2021-02-23 22:58 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
WIP patch (3.12 KB, patch)
2021-02-24 12:16 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
WIP patch (6.56 KB, patch)
2021-03-01 14:07 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (9.77 KB, patch)
2021-03-01 18:34 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2020-02-20 04:08:03 PST 
All (or alsmot all) Web inspector related tests timeout in debug builds, from at least since december-2019.
GTK debug bot has been aborting early since then.
Comment 1 Carlos Alberto Lopez Perez 2020-02-20 05:09:06 PST 
I have marked all Web inspector related tests as slow in r257051 for Debug.

I was going to mark them as timing out, but I decided to give them a run locally to check if in slow they passed and most of them did. I just marked as timing out the ones that timed out locally.

Will check on the Debug bot after the next run if there are more timing outs and if needed mark them as timing out if this continues to be an issue.
Comment 2 Carlos Alberto Lopez Perez 2020-02-20 05:09:38 PST 
See also bug 149916
Comment 3 Carlos Alberto Lopez Perez 2020-02-20 18:54:32 PST 
Ok, the debug bot has stopped exiting early due to this unexpected timeouts, and we now most of the inspector tests are completing the run in debug, just marked as slow so the testrunner gives them extra time to run.

There are still some issues with the Web inspector tests there on the last run. Many giving text failure, one timeout and one crash.

https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Tests%29/builds/5941
Comment 4 Fujii Hironori 2021-02-23 22:58:54 PST 
Created attachment 421387 [details]
WIP patch
Comment 5 Fujii Hironori 2021-02-24 12:16:40 PST 
Created attachment 421437 [details]
WIP patch
Comment 6 Fujii Hironori 2021-02-24 12:33:53 PST 
Comment on attachment 421437 [details]
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421437&action=review

> Source/WebInspectorUI/UserInterface/Protocol/MessageDispatcher.js:33
> +    const timeLimitPerRunLoop = 100; // milliseconds

This code was add by Bug 135427 (r171881). It is very old.
There should be any recent changes increasing processing time.
Comment 7 Fujii Hironori 2021-03-01 14:07:22 PST 
Created attachment 421864 [details]
WIP patch

WI.dispatchNextQueuedMessageFromBackend is using setTimeout, but
it is very slow because it is throttled by 1 second.
Comment 8 Fujii Hironori 2021-03-01 17:48:44 PST 
This is a bug ticket for Mac.
 Bug 147456 – LayoutTests/inspector frequently run slow and timeout when run in WebKit2 but not WebKit1
Comment 9 Fujii Hironori 2021-03-01 18:34:15 PST 
Created attachment 421896 [details]
Patch
Comment 10 Fujii Hironori 2021-03-01 22:59:32 PST 
Comment on attachment 421896 [details]
Patch

Clearing flags on attachment: 421896

Committed r273724 (234739@main): <https://commits.webkit.org/234739@main>
Comment 11 Fujii Hironori 2021-03-01 22:59:38 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2021-03-01 23:00:17 PST 
<rdar://problem/74912815>
Comment 13 Fujii Hironori 2021-03-01 23:01:10 PST 
*** Bug 149916 has been marked as a duplicate of this bug. ***
Comment 14 Don Olmstead 2021-03-02 07:52:08 PST 
Looks like the Windows client is also missing this switch.

Any way we could make this more cross platform?