Bug 147456 - LayoutTests/inspector frequently run slow and timeout when run in WebKit2 but not WebKit1
Summary: LayoutTests/inspector frequently run slow and timeout when run in WebKit2 but...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-30 14:50 PDT by Joseph Pecoraro
Modified: 2015-07-31 14:26 PDT (History)
10 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (5.47 KB, patch)
2015-07-30 16:05 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-07-30 14:50:58 PDT 
* SUMMARY
LayoutTests/inspector frequently run slow and timeout when run in WebKit2 but not WebKit1.

I suppose I could have used one of the existing bugs covering slow / flakey tests, but I started tackling this just as a generic issue.

* NOTES
It appears as though when running under WK2 the Inspector Process ends up throttling DOM Timers. So setTimeout(0) ends up taking ~1 second, leading to significantly slower tests.
Comment 1 Joseph Pecoraro 2015-07-30 14:51:41 PDT 
<rdar://problem/22039803>
Comment 2 Joseph Pecoraro 2015-07-30 16:05:24 PDT 
Created attachment 257864 [details]
[PATCH] Proposed Fix

This should address current unskipped flakey tests and make them run aster.

I'll have a separate change that rebases / unskips / unslows tests.
Comment 3 WebKit Commit Bot 2015-07-30 17:17:35 PDT 
Comment on attachment 257864 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 257864

Committed r187627: <http://trac.webkit.org/changeset/187627>
Comment 4 WebKit Commit Bot 2015-07-30 17:17:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2015-07-30 17:53:35 PDT 
Comment on attachment 257864 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=257864&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm:265
> +- (void)_setHiddenPageDOMTimerThrottlingEnabled:(BOOL)hiddenPageDOMTimerRhrottlingEnabled

Rhottling!
Comment 6 Joseph Pecoraro 2015-07-31 14:11:22 PDT 
(In reply to comment #5)
> Comment on attachment 257864 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257864&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm:265
> > +- (void)_setHiddenPageDOMTimerThrottlingEnabled:(BOOL)hiddenPageDOMTimerRhrottlingEnabled
> 
> Rhottling!

Oops! I'll quick fix.
Comment 7 Joseph Pecoraro 2015-07-31 14:26:48 PDT 
https://trac.webkit.org/r187682