Bug 147456 – LayoutTests/inspector frequently run slow and timeout when run in WebKit2 but not WebKit1

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
LayoutTests/inspector frequently run slow and timeout when run in WebKit2 but not WebKit1.

I suppose I could have used one of the existing bugs covering slow / flakey tests, but I started tackling this just as a generic issue.

* NOTES
It appears as though when running under WK2 the Inspector Process ends up throttling DOM Timers. So setTimeout(0) ends up taking ~1 second, leading to significantly slower tests.

[Joseph Pecoraro]

<rdar://problem/22039803>

[Joseph Pecoraro]

Created attachment 257864 [details]
[PATCH] Proposed Fix

This should address current unskipped flakey tests and make them run aster.

I'll have a separate change that rebases / unskips / unslows tests.

[WebKit Commit Bot]

Comment on attachment 257864 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 257864

Committed r187627: <http://trac.webkit.org/changeset/187627>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Comment on attachment 257864 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=257864&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm:265
> +- (void)_setHiddenPageDOMTimerThrottlingEnabled:(BOOL)hiddenPageDOMTimerRhrottlingEnabled

Rhottling!

[Joseph Pecoraro]

(In reply to comment #5)
> Comment on attachment 257864 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257864&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm:265
> > +- (void)_setHiddenPageDOMTimerThrottlingEnabled:(BOOL)hiddenPageDOMTimerRhrottlingEnabled
> 
> Rhottling!

Oops! I'll quick fix.

[Joseph Pecoraro]

https://trac.webkit.org/r187682