Bug 207507 - Use ObjectIdentifier for WebSocketStream/WebSocketChannel
Summary: Use ObjectIdentifier for WebSocketStream/WebSocketChannel
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
Keywords: InRadar
Depends on:
Reported: 2020-02-10 14:02 PST by youenn fablet
Modified: 2020-04-13 08:35 PDT (History)
4 users (show)

See Also:

Patch (31.59 KB, patch)
2020-02-10 14:06 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-02-10 14:02:01 PST
Use ObjectIdentifier for WebSocketStream/WebSocketChannel
Comment 1 youenn fablet 2020-02-10 14:06:22 PST
Created attachment 390293 [details]
Comment 2 WebKit Commit Bot 2020-02-11 06:08:35 PST
Comment on attachment 390293 [details]

Clearing flags on attachment: 390293

Committed r256303: <https://trac.webkit.org/changeset/256303>
Comment 3 WebKit Commit Bot 2020-02-11 06:08:37 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-02-11 06:09:16 PST
Comment 5 Yusuke Suzuki 2020-04-13 05:20:16 PDT
Comment on attachment 390293 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=390293&action=review

> Source/WebKit/WebProcess/Network/WebSocketChannelManager.h:51
> +    HashMap<WebSocketIdentifier, Ref<WebSocketChannel>> m_channels;

BTW, which one is responsible to removing entry from this table?
Comment 6 youenn fablet 2020-04-13 07:46:33 PDT
Thanks Yusuke, filed https://bugs.webkit.org/show_bug.cgi?id=210424
Comment 7 Yusuke Suzuki 2020-04-13 08:35:14 PDT
(In reply to youenn fablet from comment #6)
> Thanks Yusuke, filed https://bugs.webkit.org/show_bug.cgi?id=210424

Cool! Thanks :D