Bug 210424 - WebSocketChannel should remove itself from its manager map
Summary: WebSocketChannel should remove itself from its manager map
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-13 07:46 PDT by youenn fablet
Modified: 2020-04-14 02:31 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.97 KB, patch)
2020-04-13 08:19 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (5.97 KB, patch)
2020-04-14 00:33 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-04-13 07:46:23 PDT 
WebSocketChannel should remove itself from its manager map
Comment 1 youenn fablet 2020-04-13 08:19:20 PDT 
Created attachment 396282 [details]
Patch
Comment 2 Alex Christensen 2020-04-13 10:16:47 PDT 
Comment on attachment 396282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396282&action=review

> Source/WebKit/ChangeLog:9
> +        To fix this, the manager is now keeping a WeaPtr to each channel.

WeakPtr
Comment 3 youenn fablet 2020-04-14 00:33:30 PDT 
Created attachment 396386 [details]
Patch for landing
Comment 4 EWS 2020-04-14 02:30:22 PDT 
Committed r260063: <https://trac.webkit.org/changeset/260063>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396386 [details].
Comment 5 Radar WebKit Bug Importer 2020-04-14 02:31:17 PDT 
<rdar://problem/61762744>