Bug 20721 – mingw32 cross-compile from linux: VK_BACK and friends already #defined

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebKit Misc.

[Luke Kenneth Casson Leighton]

a header file in mingw32 already contains #defines for VK_BACK etc.
this causes a nice clash with the WebCore::VK_XXX const ints in
KeyboardCodes.h

[Luke Kenneth Casson Leighton]

Created attachment 23251 [details]
#ifndef around all VC_XXX consts

[Adrien Nader]

After some hacking this week-end I found out WX had the same problem.
See WebCore/config.h :
// The defines in KeyboardCodes.h conflict with Windows as well, and the only way I've found
// to address the problem is include KeyboarddCodes.h before windows.h, so do it here.

I think other builds could suffer from that too. Moreover there don't seem to be any drawback to adding those checks. Now that webkit-gtk is quite easy to get working on win32, this patch would be more than welcome. It still applies cleanly to trunk.

[Mikkel Kruse Johnsen]

This worked for me.


--- ../WebKit-r39903/WebCore/platform/gtk/KeyEventGtk.cpp	2008-12-24 23:47:40.000000000 -0500
+++ WebCore/platform/gtk/KeyEventGtk.cpp	2009-02-09 09:33:28.000000000 -0500
@@ -27,10 +27,10 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+#include "KeyboardCodes.h"
 #include "config.h"
 #include "PlatformKeyboardEvent.h"
 
-#include "KeyboardCodes.h"
 #include "NotImplemented.h"
 #include "TextEncoding.h"
 

[Csaba Osztrogonác]

*** Bug 43360 has been marked as a duplicate of this bug. ***

[Csaba Osztrogonác]

*** This bug has been marked as a duplicate of bug 43360 ***