[WK1] hiddenPageCSSAnimationSuspensionEnabled should be enabled by default for Cocoa platforms
Created attachment 389346 [details] Patch
Committed r255494: <https://trac.webkit.org/changeset/255494>
<rdar://problem/59061483>
Comment on attachment 389346 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389346&action=review > Source/WebKitLegacy/mac/WebView/WebPreferences.mm:595 > + @YES, WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey, Could you point me to the place where this setting is actually being used? I grep'd it and it looks like dead code to me.
(In reply to Chris Dumez from comment #4) > Comment on attachment 389346 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=389346&action=review > > > Source/WebKitLegacy/mac/WebView/WebPreferences.mm:595 > > + @YES, WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey, > > Could you point me to the place where this setting is actually being used? I > grep'd it and it looks like dead code to me. Nevermind, found it (bad case sensitivity check)
Comment on attachment 389346 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389346&action=review >>> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:595 >>> + @YES, WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey, >> >> Could you point me to the place where this setting is actually being used? I grep'd it and it looks like dead code to me. > > Nevermind, found it (bad case sensitivity check) However, this only does something if Page::setActivityState() gets called (so that Page::setIsVisibleInternal() gets called). I don't see Page::setActivityState() call sites in WebKitLegacy at all, only WebKit2. Am I missing something?
(In reply to Chris Dumez from comment #6) > Comment on attachment 389346 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=389346&action=review > > >>> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:595 > >>> + @YES, WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey, > >> > >> Could you point me to the place where this setting is actually being used? I grep'd it and it looks like dead code to me. > > > > Nevermind, found it (bad case sensitivity check) > > However, this only does something if Page::setActivityState() gets called > (so that Page::setIsVisibleInternal() gets called). I don't see > Page::setActivityState() call sites in WebKitLegacy at all, only WebKit2. Am > I missing something? It's called via Page::setIsVisible().
(In reply to Antoine Quint from comment #7) > (In reply to Chris Dumez from comment #6) > > Comment on attachment 389346 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=389346&action=review > > > > >>> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:595 > > >>> + @YES, WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey, > > >> > > >> Could you point me to the place where this setting is actually being used? I grep'd it and it looks like dead code to me. > > > > > > Nevermind, found it (bad case sensitivity check) > > > > However, this only does something if Page::setActivityState() gets called > > (so that Page::setIsVisibleInternal() gets called). I don't see > > Page::setActivityState() call sites in WebKitLegacy at all, only WebKit2. Am > > I missing something? > > It's called via Page::setIsVisible(). Oh, I missed that. Thanks!
(In reply to Chris Dumez from comment #8) > (In reply to Antoine Quint from comment #7) > > (In reply to Chris Dumez from comment #6) > > > Comment on attachment 389346 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=389346&action=review > > > > > > >>> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:595 > > > >>> + @YES, WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey, > > > >> > > > >> Could you point me to the place where this setting is actually being used? I grep'd it and it looks like dead code to me. > > > > > > > > Nevermind, found it (bad case sensitivity check) > > > > > > However, this only does something if Page::setActivityState() gets called > > > (so that Page::setIsVisibleInternal() gets called). I don't see > > > Page::setActivityState() call sites in WebKitLegacy at all, only WebKit2. Am > > > I missing something? > > > > It's called via Page::setIsVisible(). > > Oh, I missed that. Thanks! Easy when you've been staring at stack traces all day :)