Bug 207014 - [Web Animations] DocumentTimeline shouldn't suspend itself if hiddenPageCSSAnimationSuspensionEnabled is disabled
Summary: [Web Animations] DocumentTimeline shouldn't suspend itself if hiddenPageCSSAn...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-30 12:29 PST by Antoine Quint
Modified: 2020-01-31 08:18 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.72 KB, patch)
2020-01-30 12:31 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (2.79 KB, patch)
2020-01-31 00:50 PST, Antoine Quint 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-01-30 12:29:23 PST 
[Web Animations] DocumentTimeline shouldn't suspend itself
Comment 1 Antoine Quint 2020-01-30 12:31:33 PST 
Created attachment 389276 [details]
Patch
Comment 2 Antoine Quint 2020-01-30 12:31:38 PST 
<rdar://problem/58815952>
Comment 3 Jon Lee 2020-01-30 14:18:12 PST 
Comment on attachment 389276 [details]
Patch

it didn't work
Comment 4 Antoine Quint 2020-01-31 00:50:47 PST 
Created attachment 389335 [details]
Patch
Comment 5 Antoine Quint 2020-01-31 02:20:23 PST 
Committed r255489: <https://trac.webkit.org/changeset/255489>
Comment 6 Antti Koivisto 2020-01-31 02:27:55 PST 
Comment on attachment 389335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=389335&action=review

> Source/WebCore/animation/DocumentTimeline.cpp:70
> +            if (page->settings().hiddenPageCSSAnimationSuspensionEnabled() && !page->isVisible())

Wonder why we need hiddenPageCSSAnimationSuspensionEnabled flag at all? What is the case where we wouldn't want to suspend non-visible pages?