RESOLVED FIXED 207014
[Web Animations] DocumentTimeline shouldn't suspend itself if hiddenPageCSSAnimationSuspensionEnabled is disabled 
https://bugs.webkit.org/show_bug.cgi?id=207014
Summary [Web Animations] DocumentTimeline shouldn't suspend itself if hiddenPageCSSAn...
Antoine Quint
Reported 2020-01-30 12:29:23 PST
[Web Animations] DocumentTimeline shouldn't suspend itself
Attachments
Patch (1.72 KB, patch)
2020-01-30 12:31 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (2.79 KB, patch)
2020-01-31 00:50 PST, Antoine Quint 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2020-01-30 12:31:33 PST
Created attachment 389276 [details] Patch
Antoine Quint
Comment 2 2020-01-30 12:31:38 PST
<rdar://problem/58815952>
Jon Lee
Comment 3 2020-01-30 14:18:12 PST
Comment on attachment 389276 [details] Patch it didn't work
Antoine Quint
Comment 4 2020-01-31 00:50:47 PST
Created attachment 389335 [details] Patch
Antoine Quint
Comment 5 2020-01-31 02:20:23 PST
Committed r255489: <https://trac.webkit.org/changeset/255489>
Antti Koivisto
Comment 6 2020-01-31 02:27:55 PST
Comment on attachment 389335 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389335&action=review > Source/WebCore/animation/DocumentTimeline.cpp:70 > + if (page->settings().hiddenPageCSSAnimationSuspensionEnabled() && !page->isVisible()) Wonder why we need hiddenPageCSSAnimationSuspensionEnabled flag at all? What is the case where we wouldn't want to suspend non-visible pages?
Note You need to log in before you can comment on or make changes to this bug.