Bug 206720 – Break the dependency between jsc and DerivedSources

• Status: REOPENED
• Component: JavaScriptCore

[Robin Morisset]

According to Tadeu, the slowdown of production builds (by more than 20%) when he landed his bytecode patch was caused by a new dependency of the jsc binary on DerivedSources/, which was needed because of DerivedSources/BytecodeStructs.h being included in CommonSlowPaths.h which is transitively included in jsc.cpp.
Now that BytecodeStructs.h is no longer included in CommonSlowPaths.cpp (see https://bugs.webkit.org/show_bug.cgi?id=206566), I'd like to see if the dependency can be safely removed, to recover this compile time regression.

[Robin Morisset]

Created attachment 388627 [details]
Patch

[Mark Lam]

Comment on attachment 388627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388627&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        Now that BytecodeStructs.h is no longer included in CommonSlowPaths.cpp (see https://bugs.webkit.org/show_bug.cgi?id=206566), I'm trying to break the dependency, to recover from this compile time regression.

I think you mean CommonSlowPaths.h here.

[Robin Morisset]

(In reply to Mark Lam from comment #2)
> Comment on attachment 388627 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388627&action=review
> 
> > Source/JavaScriptCore/ChangeLog:9
> > +        Now that BytecodeStructs.h is no longer included in CommonSlowPaths.cpp (see https://bugs.webkit.org/show_bug.cgi?id=206566), I'm trying to break the dependency, to recover from this compile time regression.
> 
> I think you mean CommonSlowPaths.h here.

Yes, it was a typo

[Robin Morisset]

Created attachment 388646 [details]
Patch

Fixed the typo in the changelog.

[WebKit Commit Bot]

Comment on attachment 388646 [details]
Patch

Clearing flags on attachment: 388646

Committed r255052: <https://trac.webkit.org/changeset/255052>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58858767>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 206758