Bug 206566 - Don't include BytecodeStructs.h in CommonSlowPaths.h
Summary: Don't include BytecodeStructs.h in CommonSlowPaths.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks: 206720
  Show dependency tree / graph
 
Reported: 2020-01-21 19:18 PST by Robin Morisset
Modified: 2020-01-23 17:18 PST (History)
8 users (show)

See Also:

Attachments
WIP (26.60 KB, patch)
2020-01-21 19:21 PST, Robin Morisset 		no flags Details | Formatted Diff | Diff
Patch (25.69 KB, patch)
2020-01-23 11:44 PST, Robin Morisset 		no flags Details | Formatted Diff | Diff
Patch (25.73 KB, patch)
2020-01-23 14:25 PST, Robin Morisset 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2020-01-21 19:18:27 PST 
BytecodeStructs.h is quite large, even after https://bugs.webkit.org/show_bug.cgi?id=206563 (roughly 40k lines). It is currently inlined in CommonSlowPaths.h just for 2 functions, which are only used in 2 cpp files.
Not only is CommonSlowPaths.h directly included in many places, but it it is also included in JIT.h, which is included by something like half of JSC.

By only including BytecodeStructs.h in a more specialized CommonSlowPathsInlines.h I hope to improve compile times.
Comment 1 Robin Morisset 2020-01-21 19:21:18 PST 
Created attachment 388390 [details]
WIP

I only have to actually measure the compile times for the Changelog, this patch is otherwise ready.
Comment 2 Robin Morisset 2020-01-23 11:44:51 PST 
Created attachment 388570 [details]
Patch

The compile time improvement is sadly too small to measure in the noise, but I still think it is worth landing as it is a fairly trivial patch.
I've also fixed the patch, as the new file was added in the wrong directory, and two forward declarations are no longer needed.
Comment 3 Robin Morisset 2020-01-23 14:25:48 PST 
Created attachment 388591 [details]
Patch

Fixing style nits.
Comment 4 Tadeu Zagallo 2020-01-23 14:40:58 PST 
Comment on attachment 388591 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2020-01-23 15:25:37 PST 
Comment on attachment 388591 [details]
Patch

Clearing flags on attachment: 388591

Committed r255040: <https://trac.webkit.org/changeset/255040>
Comment 6 WebKit Commit Bot 2020-01-23 15:25:39 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-01-23 15:26:18 PST 
<rdar://problem/58851022>