Bug 206712 - Add a variant of -selectPositionAtPoint that can select an arbitrary point
Summary: Add a variant of -selectPositionAtPoint that can select an arbitrary point
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-23 16:01 PST by Daniel Bates
Modified: 2020-04-18 09:24 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.57 KB, patch)
2020-01-23 16:05 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
To Land (3.56 KB, patch)
2020-01-23 16:09 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
To land after bug #207366 (71.86 KB, patch)
2020-02-07 09:43 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-01-23 16:01:13 PST 
Add a variant of -selectPositionAtPoint that takes a boolean as to whether to constrain the point to stay within the focused element. This will be used in a future patch to select an arbitrary point on the page regardless of whether doing so changes focus.
Comment 1 Daniel Bates 2020-01-23 16:05:56 PST 
Created attachment 388607 [details]
Patch
Comment 2 Daniel Bates 2020-01-23 16:08:01 PST 
Comment on attachment 388607 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388607&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:450
> +- (void)_selectPositionAtPoint:(CGPoint)point stayingWithinFocusedElement:(BOOL)isInteractingWithFocusedElement completionHandler:(void (^)(void))completionHandler;

isInteractingWithFocusedElement => stayingWithinFocusedElement
Comment 3 Daniel Bates 2020-01-23 16:09:40 PST 
Created attachment 388609 [details]
To Land
Comment 4 Daniel Bates 2020-01-23 16:11:00 PST 
Comment on attachment 388609 [details]
To Land

Clearing flags on attachment: 388609

Committed r255042: <https://trac.webkit.org/changeset/255042>
Comment 5 Daniel Bates 2020-01-23 16:11:01 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-01-23 16:11:11 PST 
<rdar://problem/58852706>
Comment 7 Daniel Bates 2020-02-07 09:43:22 PST Comment hidden (obsolete)
Comment 8 Daniel Bates 2020-02-07 09:43:22 PST Comment hidden (obsolete)