RESOLVED FIXED207366
Legacy WebKit: Have linkedOnOrAfter() respect the NSDefault WebKitLinkedOnOrAfterEverything and opt DumpRenderTree in 
https://bugs.webkit.org/show_bug.cgi?id=207366
Summary Legacy WebKit: Have linkedOnOrAfter() respect the NSDefault WebKitLinkedOnOrA...
Daniel Bates
Reported 2020-02-06 15:57:41 PST
Bug #168124 added support for making linkedOnOrAfter() always return true if the NSDefault WebKitLinkedOnOrAfterEverything was enabled and it set this default in all WebKit2 tools. Later in bug #168388 linkedOnOrAfter() was added to Legacy WebKit, but it lacked similar behavior as its WebKit2 counterpart though it shares the exact same interface. As a result of this asymmetry, tests results will need to go in different directories for Legacy WebKit and Modern WebKit: the former *must* go into platform-specific WK1 test directories while the latter *could* be placed with other platform-independent tests. This is inconvenient. We should fix this.
Attachments
Patch (3.58 KB, patch)
2020-02-06 16:06 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (3.99 KB, patch)
2020-02-07 09:57 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2020-02-06 16:06:44 PST
Created attachment 390018 [details] Patch
Daniel Bates
Comment 2 2020-02-07 09:38:57 PST
Comment on attachment 390018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390018&action=review > Source/WebKitLegacy/mac/ChangeLog:9 > + always return true. + This lets me put test results for Mac and iOS Legacy WebKit in the same cross-platform directory + as the actual test instead of under a platform-specific directory
Daniel Bates
Comment 3 2020-02-07 09:57:07 PST
Created attachment 390095 [details] Patch No code change. Just updated the ChangeLog to explain more.
Brent Fulgham
Comment 4 2020-02-07 10:45:19 PST
Comment on attachment 390095 [details] Patch r=me
Daniel Bates
Comment 5 2020-02-07 13:05:39 PST
Thank you.
Daniel Bates
Comment 6 2020-02-07 13:17:01 PST
Comment on attachment 390095 [details] Patch Clearing flags on attachment: 390095 Committed r256054: <https://trac.webkit.org/changeset/256054>
Daniel Bates
Comment 7 2020-02-07 13:17:04 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-02-07 13:18:21 PST
<rdar://problem/59270724>
Note You need to log in before you can comment on or make changes to this bug.