Bug 207366 - Legacy WebKit: Have linkedOnOrAfter() respect the NSDefault WebKitLinkedOnOrAfterEverything and opt DumpRenderTree in
Summary: Legacy WebKit: Have linkedOnOrAfter() respect the NSDefault WebKitLinkedOnOrA...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
Keywords: InRadar
Depends on:
Reported: 2020-02-06 15:57 PST by Daniel Bates
Modified: 2020-02-07 13:18 PST (History)
2 users (show)

See Also:

Patch (3.58 KB, patch)
2020-02-06 16:06 PST, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (3.99 KB, patch)
2020-02-07 09:57 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-02-06 15:57:41 PST
Bug #168124 added support for making linkedOnOrAfter() always return true if the NSDefault WebKitLinkedOnOrAfterEverything was enabled and it set this default in all WebKit2 tools. Later in bug #168388 linkedOnOrAfter() was added to Legacy WebKit, but it lacked similar behavior as its WebKit2 counterpart though it shares the exact same interface. As a result of this asymmetry, tests results will need to go in different directories for Legacy WebKit and Modern WebKit: the former *must* go into platform-specific WK1 test directories while the latter *could* be placed with other platform-independent tests. This is inconvenient. We should fix this.
Comment 1 Daniel Bates 2020-02-06 16:06:44 PST
Created attachment 390018 [details]
Comment 2 Daniel Bates 2020-02-07 09:38:57 PST
Comment on attachment 390018 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=390018&action=review

> Source/WebKitLegacy/mac/ChangeLog:9
> +        always return true.

+        This lets me put test results for Mac and iOS Legacy WebKit in the same cross-platform directory
+        as the actual test instead of under a platform-specific directory
Comment 3 Daniel Bates 2020-02-07 09:57:07 PST
Created attachment 390095 [details]

No code change. Just updated the ChangeLog to explain more.
Comment 4 Brent Fulgham 2020-02-07 10:45:19 PST
Comment on attachment 390095 [details]

Comment 5 Daniel Bates 2020-02-07 13:05:39 PST
Thank you.
Comment 6 Daniel Bates 2020-02-07 13:17:01 PST
Comment on attachment 390095 [details]

Clearing flags on attachment: 390095

Committed r256054: <https://trac.webkit.org/changeset/256054>
Comment 7 Daniel Bates 2020-02-07 13:17:04 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-02-07 13:18:21 PST