Bug 206612 - uniqueLogIdentifier() should generate a unique identifiers
Summary: uniqueLogIdentifier() should generate a unique identifiers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on: 200403
Blocks:
  Show dependency tree / graph
 
Reported: 2020-01-22 13:59 PST by Eric Carlson
Modified: 2020-01-22 18:25 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.34 KB, patch)
2020-01-22 14:03 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2020-01-22 13:59:33 PST 
uniqueLogIdentifier() should generate a unique identifiers
Comment 1 Eric Carlson 2020-01-22 14:03:14 PST 
Created attachment 388467 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-01-22 15:43:51 PST 
<rdar://problem/58814158>
Comment 3 Brent Fulgham 2020-01-22 17:27:55 PST 
Comment on attachment 388467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388467&action=review

r=me

> Source/WTF/wtf/LoggerHelper.h:69
> +        uint64_t lowWord = cryptographicallyRandomNumber();

Whoops!
Comment 4 WebKit Commit Bot 2020-01-22 18:25:29 PST 
Comment on attachment 388467 [details]
Patch

Clearing flags on attachment: 388467

Committed r254956: <https://trac.webkit.org/changeset/254956>
Comment 5 WebKit Commit Bot 2020-01-22 18:25:31 PST 
All reviewed patches have been landed.  Closing bug.