Bug 200403 – uniqueLogIdentifier() should generate a 64-bit identifier

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Carlson]

uniqueLogIdentifier() should generate a 64-bit identifier

[Radar WebKit Bug Importer]

<rdar://problem/53878447>

[Eric Carlson]

Created attachment 375452 [details]
Patch

[youenn fablet]

Comment on attachment 375452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375452&action=review

> Source/WTF/ChangeLog:12
> +        uint32_t so use two to generate a 64-bit identifier.

Maybe we should have a way to print parent id as ABCD and child log identifier as ABCD-EFGH so that it is easier to spot the relationship between parent and child.
32 bits is probably enough for parent ids so that any id above 2^32 would be printed as a child identifier.

[Eric Carlson]

(In reply to youenn fablet from comment #3)
> Comment on attachment 375452 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375452&action=review
> 
> > Source/WTF/ChangeLog:12
> > +        uint32_t so use two to generate a 64-bit identifier.
> 
> Maybe we should have a way to print parent id as ABCD and child log
> identifier as ABCD-EFGH so that it is easier to spot the relationship
> between parent and child.
> 32 bits is probably enough for parent ids so that any id above 2^32 would be
> printed as a child identifier.

Good idea, I'll think about the best way to do that.

[WebKit Commit Bot]

Comment on attachment 375452 [details]
Patch

Clearing flags on attachment: 375452

Committed r248183: <https://trac.webkit.org/changeset/248183>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.