Bug 206366 - Regression(r253224) No longer able to prevent a tab from closing via the beforeunload prompt
Summary: Regression(r253224) No longer able to prevent a tab from closing via the befo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 204950
  Show dependency tree / graph
 
Reported: 2020-01-16 11:50 PST by Chris Dumez
Modified: 2023-04-23 14:07 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.62 KB, patch)
2020-01-16 11:55 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-01-16 11:50:04 PST 
We are no longer able to prevent a tab from closing via the beforeunload prompt since r253224.
Comment 1 Chris Dumez 2020-01-16 11:50:29 PST 
<rdar://problem/58537467>
Comment 2 Chris Dumez 2020-01-16 11:55:50 PST 
Created attachment 387941 [details]
Patch
Comment 3 Geoffrey Garen 2020-01-16 13:51:01 PST 
Comment on attachment 387941 [details]
Patch

r=me

are the iOS-wk2 EWS crashes related?
Comment 4 Chris Dumez 2020-01-16 14:12:51 PST 
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 387941 [details]
> Patch
> 
> r=me
> 
> are the iOS-wk2 EWS crashes related?

Doesn't look like it, the bubbles are green now.
Comment 5 WebKit Commit Bot 2020-01-16 14:57:48 PST 
Comment on attachment 387941 [details]
Patch

Clearing flags on attachment: 387941

Committed r254711: <https://trac.webkit.org/changeset/254711>
Comment 6 WebKit Commit Bot 2020-01-16 14:57:49 PST 
All reviewed patches have been landed.  Closing bug.