Bug 204950 - Reduce timeout for page to handle beforeunload events when trying to close a page
Summary: Reduce timeout for page to handle beforeunload events when trying to close a ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 206366 207121
Blocks:
  Show dependency tree / graph
 
Reported: 2019-12-06 09:03 PST by Chris Dumez
Modified: 2020-02-03 08:58 PST (History)
7 users (show)

See Also:

Attachments
Patch (5.09 KB, patch)
2019-12-06 09:08 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-12-06 09:03:15 PST 
Reduce timeout for page to handle beforeunload events when trying to close a page. It may currently take up to 3 seconds to actually close a tab after the user clicks on the "X" to close it. This is because we wait for the page to fire and handle the beforeunload events and only give up after 3 seconds. I propose we reduce this timeout to something more reasonable from a user standpoint (e.g. 500ms, no more than 1 second).
Comment 1 Radar WebKit Bug Importer 2019-12-06 09:03:34 PST 
<rdar://problem/57700419>
Comment 2 Chris Dumez 2019-12-06 09:08:15 PST 
Created attachment 385021 [details]
Patch
Comment 3 WebKit Commit Bot 2019-12-06 15:02:18 PST 
Comment on attachment 385021 [details]
Patch

Clearing flags on attachment: 385021

Committed r253224: <https://trac.webkit.org/changeset/253224>
Comment 4 WebKit Commit Bot 2019-12-06 15:02:19 PST 
All reviewed patches have been landed.  Closing bug.