Bug 206125 - [WebCore] Fix crash in module loader due to change in fragment reservation
Summary: [WebCore] Fix crash in module loader due to change in fragment reservation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-10 21:43 PST by Yusuke Suzuki
Modified: 2020-01-11 17:26 PST (History)
4 users (show)

See Also:


Attachments
Patch (5.96 KB, patch)
2020-01-10 21:46 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (6.10 KB, patch)
2020-01-10 21:53 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (7.90 KB, patch)
2020-01-10 22:27 PST, Yusuke Suzuki
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-01-10 21:43:54 PST
At some point, CachedResource::url() starts returning URL without fragment.
This breaks invariant in module loader and one of WPT test is crashing.
Comment 1 Yusuke Suzuki 2020-01-10 21:46:30 PST
Created attachment 387422 [details]
Patch
Comment 2 Yusuke Suzuki 2020-01-10 21:53:16 PST
Created attachment 387423 [details]
Patch
Comment 3 Yusuke Suzuki 2020-01-10 21:56:45 PST
Maybe, this? https://bugs.webkit.org/show_bug.cgi?id=159705
Comment 4 Yusuke Suzuki 2020-01-10 22:27:28 PST
Created attachment 387426 [details]
Patch
Comment 5 Yusuke Suzuki 2020-01-11 17:25:29 PST
Committed r254408: <https://trac.webkit.org/changeset/254408>
Comment 6 Radar WebKit Bug Importer 2020-01-11 17:26:14 PST
<rdar://problem/58507472>