Bug 159705 - [Fetch API] Request and Response url getter should use URL serialization
Summary: [Fetch API] Request and Response url getter should use URL serialization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks: 151937
  Show dependency treegraph
 
Reported: 2016-07-13 01:23 PDT by youenn fablet
Modified: 2016-07-14 03:15 PDT (History)
2 users (show)

See Also:


Attachments
Patch (146.98 KB, patch)
2016-07-13 02:06 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (142.77 KB, patch)
2016-07-14 02:46 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-07-13 01:23:49 PDT
As per fetch spec, urls should be serialized following https://url.spec.whatwg.org/#concept-url-serializer.
Comment 1 youenn fablet 2016-07-13 02:06:21 PDT
Created attachment 283496 [details]
Patch
Comment 2 Alex Christensen 2016-07-13 08:55:31 PDT
Comment on attachment 283496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283496&action=review

> Source/WebCore/platform/URL.h:120
> +    bool hasUser()const;
> +    bool hasPassword()const;
> +    bool hasQuery()const;
> +    bool hasFragment() const;

All of these should have spaces before const.
Comment 3 youenn fablet 2016-07-14 02:46:13 PDT
Created attachment 283629 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2016-07-14 03:15:41 PDT
Comment on attachment 283629 [details]
Patch for landing

Clearing flags on attachment: 283629

Committed r203221: <http://trac.webkit.org/changeset/203221>
Comment 5 WebKit Commit Bot 2016-07-14 03:15:46 PDT
All reviewed patches have been landed.  Closing bug.