RESOLVED FIXED Bug 206066
Introduce an abstract SampleBufferDisplayLayer 
https://bugs.webkit.org/show_bug.cgi?id=206066
Summary Introduce an abstract SampleBufferDisplayLayer
youenn fablet
Reported 2020-01-10 07:54:57 PST
Introduce an abstract SampleBufferDisplayLayer
Attachments
Patch (52.52 KB, patch)
2020-01-10 08:52 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (53.82 KB, patch)
2020-01-10 09:10 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (53.82 KB, patch)
2020-01-10 09:20 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (52.16 KB, patch)
2020-01-13 05:48 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (54.47 KB, patch)
2020-01-15 05:03 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (54.42 KB, patch)
2020-01-15 05:41 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (54.32 KB, patch)
2020-01-20 00:36 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-01-10 08:52:47 PST
Created attachment 387340 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-01-10 08:53:18 PST
<rdar://problem/58480181>
youenn fablet
Comment 3 2020-01-10 09:10:02 PST
Created attachment 387343 [details] Patch
youenn fablet
Comment 4 2020-01-10 09:20:13 PST
Created attachment 387346 [details] Patch
Eric Carlson
Comment 5 2020-01-10 09:47:48 PST
Comment on attachment 387346 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387346&action=review > Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:118 > + callOnMainThread([protectedSelf = RetainPtr<WebAVSampleBufferStatusChangeListener>(self), layer = WTFMove(layer), status = WTFMove(status)] { Nit: layer and status aren't used in the lambda. > Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:129 > + callOnMainThread([protectedSelf = RetainPtr<WebAVSampleBufferStatusChangeListener>(self), layer = WTFMove(layer), status = WTFMove(status)] { Ditto
youenn fablet
Comment 6 2020-01-13 05:48:11 PST
Created attachment 387518 [details] Patch
WebKit Commit Bot
Comment 7 2020-01-14 05:47:50 PST
Comment on attachment 387518 [details] Patch Rejecting attachment 387518 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 387518, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog is not at the top of the file. Full output: https://webkit-queues.webkit.org/results/13303942
youenn fablet
Comment 8 2020-01-15 05:03:42 PST
Created attachment 387778 [details] Patch for landing
WebKit Commit Bot
Comment 9 2020-01-15 05:15:33 PST
Comment on attachment 387778 [details] Patch for landing Rejecting attachment 387778 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 387778, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog is not at the top of the file. Full output: https://webkit-queues.webkit.org/results/13304732
youenn fablet
Comment 10 2020-01-15 05:41:20 PST
Created attachment 387781 [details] Patch for landing
WebKit Commit Bot
Comment 11 2020-01-15 06:24:16 PST
Comment on attachment 387781 [details] Patch for landing Clearing flags on attachment: 387781 Committed r254564: <https://trac.webkit.org/changeset/254564>
WebKit Commit Bot
Comment 12 2020-01-15 06:24:18 PST
All reviewed patches have been landed. Closing bug.
Matt Lewis
Comment 13 2020-01-17 16:41:38 PST
Reverted r254564 for reason: This caused internal test crashes. Committed r254779: <https://trac.webkit.org/changeset/254779>
youenn fablet
Comment 14 2020-01-20 00:36:10 PST
Created attachment 388211 [details] Patch for landing
WebKit Commit Bot
Comment 15 2020-01-20 01:19:40 PST
Comment on attachment 388211 [details] Patch for landing Clearing flags on attachment: 388211 Committed r254813: <https://trac.webkit.org/changeset/254813>
WebKit Commit Bot
Comment 16 2020-01-20 01:19:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.