Bug 206060 - Clean-up MediaPlayerPrivateMediaStreamAVFObjC.h/.mm
Summary: Clean-up MediaPlayerPrivateMediaStreamAVFObjC.h/.mm
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
Keywords: InRadar
Depends on:
Blocks: 206066
  Show dependency treegraph
Reported: 2020-01-10 04:05 PST by youenn fablet
Modified: 2020-01-13 15:58 PST (History)
9 users (show)

See Also:

Patch (3.47 KB, patch)
2020-01-10 04:07 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (3.47 KB, patch)
2020-01-12 23:54 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-01-10 04:05:12 PST
Clean-up MediaPlayerPrivateMediaStreamAVFObjC.h
Comment 1 youenn fablet 2020-01-10 04:07:17 PST
Created attachment 387328 [details]
Comment 2 Eric Carlson 2020-01-10 09:36:05 PST
Comment on attachment 387328 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=387328&action=review

> Source/WebCore/ChangeLog:3
> +        Clean-up MediaPlayerPrivateMediaStreamAVFObjC.h

Nit: should probably update the bug name as you change both files.
Comment 3 youenn fablet 2020-01-12 23:54:56 PST
Created attachment 387504 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2020-01-13 09:26:30 PST
Comment on attachment 387504 [details]
Patch for landing

Rejecting attachment 387504 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 387504, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=387504&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=206060&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 387504 from bug 206060.
Fetching: https://bugs.webkit.org/attachment.cgi?id=387504
Authentication required
Authentication required
Authentication required
Updating OpenSource
From https://git.webkit.org/git/WebKit
   17265b441d3..7eacf652640  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 254432 = 17265b441d342970b25dd93a8c7dc69af9f0b850
r254433 = c3d5144b66238a19c3916664b516c548b90bd94a
r254434 = 7eacf65264049f66dea65e31ab84c9e12ef9b8d1
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/13303512
Comment 5 WebKit Commit Bot 2020-01-13 15:57:57 PST
Comment on attachment 387504 [details]
Patch for landing

Clearing flags on attachment: 387504

Committed r254465: <https://trac.webkit.org/changeset/254465>
Comment 6 WebKit Commit Bot 2020-01-13 15:57:59 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-01-13 15:58:14 PST