Bug 205991 - Bad baseline for Catalina on xhr web-platform-tests imported in r254154
Summary: Bad baseline for Catalina on xhr web-platform-tests imported in r254154
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pablo Saavedra
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-08 23:32 PST by Pablo Saavedra
Modified: 2020-01-09 11:53 PST (History)
7 users (show)

See Also:

Attachments
patch (4.63 KB, patch)
2020-01-08 23:34 PST, Pablo Saavedra 		no flags Details | Formatted Diff | Diff
patch (4.68 KB, patch)
2020-01-09 11:13 PST, Pablo Saavedra 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo Saavedra 2020-01-08 23:32:00 PST 
Related to: https://bugs.webkit.org/show_bug.cgi?id=205641 (Re-sync web-platform-tests/xhr from upstream)

Requires a baseline rebasing
Comment 1 Pablo Saavedra 2020-01-08 23:34:29 PST 
Created attachment 387196 [details]
patch
Comment 2 Pablo Saavedra 2020-01-09 02:58:01 PST 
Testing the new patch in my local macpro with catalina:

```
macpro:WebKit psaavedra$ system_profiler SPSoftwareDataType | grep Version
      System Version: macOS 10.15.2 (19C57)
      Kernel Version: Darwin 19.2.0


macpro:WebKit psaavedra$ cat ooo.out 
python ./Tools/Scripts/run-webkit-tests --no-build --no-show-results --no-new-test-results --clobber-old-results --exit-after-n-crashes-or-timeouts 50 --exit-after-n-failures 500 --release --results-directory layout-test-results --no-retry-failures LayoutTests/imported/w3c/web-platform-tests/xhr/getallresponseheaders.htm

Using port 'mac-catalina-wk2'
Test configuration: <catalina, x86_64, release>
Placing test results in /Volumes/external/psaavedra/WebKit/layout-test-results
Using Release build
Pixel tests disabled
Regular timeout: 30000, slow test timeout: 150000
Command line: /Volumes/external/psaavedra/WebKit/WebKitBuild/Release/WebKitTestRunner -

Collecting tests ...
Parsing expectations ...
Found 1 test; running 1, skipping 0.
Checking build ...
Clobbering old results in /Volumes/external/psaavedra/WebKit/layout-test-results

Verbose baseline search path: platform/mac-catalina-wk2 -> platform/mac-catalina -> platform/mac-wk2 -> platform/mac -> platform/wk2 -> generic

Baseline search path: platform/mac-wk2 -> platform/mac -> platform/wk2 -> generic

Running 1 test

Starting helper ...
Checking system dependencies ...
Sharding tests ...
Running 1 WebKitTestRunner.

Starting 1 worker ...

The test ran as expected.
```
Comment 3 Pablo Saavedra 2020-01-09 08:24:44 PST 
Failed tests in ios-wk2 are not related with xhr.
Comment 4 Pablo Saavedra 2020-01-09 11:13:47 PST 
Created attachment 387246 [details]
patch
Comment 5 Pablo Saavedra 2020-01-09 11:20:26 PST 
The queues in EWS are being slower than usual. Because I've tested the changes in Catalina (in local), I've decided to send the patch to the commit queue at last.
Comment 6 WebKit Commit Bot 2020-01-09 11:52:20 PST 
Comment on attachment 387246 [details]
patch

Clearing flags on attachment: 387246

Committed r254285: <https://trac.webkit.org/changeset/254285>
Comment 7 WebKit Commit Bot 2020-01-09 11:52:22 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-01-09 11:53:15 PST 
<rdar://problem/58451641>