RESOLVED FIXED205641
Re-sync web-platform-tests/xhr from upstream 
https://bugs.webkit.org/show_bug.cgi?id=205641
Summary Re-sync web-platform-tests/xhr from upstream
Pablo Saavedra
Reported 2019-12-30 03:58:22 PST
Re-sync web-platform-tests/xhr from upstream
Attachments
patch (332.54 KB, patch)
2019-12-30 04:08 PST, Pablo Saavedra 		no flags
DetailsFormatted DiffDiff
patch (142.99 KB, patch)
2020-01-07 04:38 PST, Pablo Saavedra 		no flags
DetailsFormatted DiffDiff
patch (142.99 KB, patch)
2020-01-07 06:34 PST, Pablo Saavedra 		no flags
DetailsFormatted DiffDiff
patch (also fixing small nits respect the previous version) (314.03 KB, patch)
2020-01-07 07:18 PST, Pablo Saavedra 		no flags
DetailsFormatted DiffDiff
patch (also fixing small nits respect the previous version) (316.11 KB, patch)
2020-01-07 08:06 PST, Pablo Saavedra 		no flags
DetailsFormatted DiffDiff
patch (also fixing small nits respect the previous version) (316.03 KB, patch)
2020-01-07 09:27 PST, Pablo Saavedra 		no flags
DetailsFormatted DiffDiff
patch (also fixing small nits respect the previous version) (316.59 KB, patch)
2020-01-07 13:17 PST, Pablo Saavedra 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Pablo Saavedra
Comment 1 2019-12-30 04:08:00 PST
Created attachment 386522 [details] patch
Pablo Saavedra
Comment 2 2019-12-30 04:12:43 PST
Some expectations were removed from the TestExpectations files because the tests not longer exist: * webkit.org/b/182849 imported/w3c/web-platform-tests/xhr/event-upload-progress-crossorigin.htm [ Pass Failure ] (Which was currently CLOSED) * webkit.org/b/180554 imported/w3c/web-platform-tests/xhr/event-upload-progress-crossorigin.htm [ Skip ] (still open) es un crash
Pablo Saavedra
Comment 3 2020-01-07 04:38:54 PST
Created attachment 386960 [details] patch
Pablo Saavedra
Comment 4 2020-01-07 06:34:15 PST
Created attachment 386964 [details] patch
Pablo Saavedra
Comment 5 2020-01-07 07:18:10 PST
Created attachment 386967 [details] patch (also fixing small nits respect the previous version)
Pablo Saavedra
Comment 6 2020-01-07 07:20:33 PST
Thanks Youenn for the review. I just uploaded a new version just fixing up small nits
Pablo Saavedra
Comment 7 2020-01-07 08:06:42 PST
Created attachment 386975 [details] patch (also fixing small nits respect the previous version)
Pablo Saavedra
Comment 8 2020-01-07 09:27:08 PST
Created attachment 386978 [details] patch (also fixing small nits respect the previous version)
Pablo Saavedra
Comment 9 2020-01-07 12:23:00 PST
* the failed http/tests/appcache/main-resource-redirect-with-sw.html in ios-wk2 has no relationship with this patch * api-ios fails are not related with w3c importation as well.
Pablo Saavedra
Comment 10 2020-01-07 13:17:08 PST
Created attachment 387022 [details] patch (also fixing small nits respect the previous version)
WebKit Commit Bot
Comment 11 2020-01-07 13:58:44 PST
Comment on attachment 387022 [details] patch (also fixing small nits respect the previous version) Clearing flags on attachment: 387022 Committed r254154: <https://trac.webkit.org/changeset/254154>
WebKit Commit Bot
Comment 12 2020-01-07 13:58:46 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2020-01-07 13:59:19 PST
<rdar://problem/58386946>
Truitt Savell
Comment 14 2020-01-08 13:50:13 PST
It looks like the changes in https://trac.webkit.org/changeset/254154/webkit broke imported/w3c/web-platform-tests/xhr/getallresponseheaders.htm History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fxhr%2Fgetallresponseheaders.htm Diff: --- /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk1/build/layout-test-results/imported/w3c/web-platform-tests/xhr/getallresponseheaders-actual.txt @@ -4,6 +4,6 @@ PASS XMLHttpRequest: getAllResponseHeaders() 2 PASS XMLHttpRequest: getAllResponseHeaders() 3 PASS XMLHttpRequest: getAllResponseHeaders() 4 -FAIL XMLHttpRequest: getAllResponseHeaders() 5 assert_equals: expected "heya: , \v\f, 1, , , 2\r\n" but got "heya: , , 1, , , 2\r\n" +PASS XMLHttpRequest: getAllResponseHeaders() 5 PASS XMLHttpRequest: getAllResponseHeaders() 6 Looks like it just needs a rebasline though
Truitt Savell
Comment 15 2020-01-08 13:50:32 PST
This is only failing on Catalina
Pablo Saavedra
Comment 16 2020-01-08 23:02:37 PST
(In reply to Truitt Savell from comment #15) > This is only failing on Catalina a specific baseline for this subset is needed.
Pablo Saavedra
Comment 17 2020-01-09 00:05:03 PST
(In reply to Pablo Saavedra from comment #16) > (In reply to Truitt Savell from comment #15) > > This is only failing on Catalina > > a specific baseline for this subset is needed. Fixing this is https://bugs.webkit.org/show_bug.cgi?id=205991
Truitt Savell
Comment 18 2020-01-09 16:50:50 PST
This new test imported/w3c/web-platform-tests/xhr/event-timeout-order.any.html added in https://trac.webkit.org/changeset/254154/webkit is flakey. History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fxhr%2Fevent-timeout-order.any.html
Pablo Saavedra
Comment 19 2020-01-09 20:38:43 PST
(In reply to Truitt Savell from comment #18) > This new test > imported/w3c/web-platform-tests/xhr/event-timeout-order.any.html > > added in https://trac.webkit.org/changeset/254154/webkit > > is flakey. History: > > https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb- > platform-tests%2Fxhr%2Fevent-timeout-order.any.html Fixed in https://bugs.webkit.org/show_bug.cgi?id=206053
Note You need to log in before you can comment on or make changes to this bug.