Bug 205957 – We should pass in -parallelizeTargets for the JavaScriptCore xcodebuild

• Status: REOPENED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

Created attachment 387144 [details]
patch

[Keith Miller]

Comment on attachment 387144 [details]
patch

r=me.

[WebKit Commit Bot]

Comment on attachment 387144 [details]
patch

Clearing flags on attachment: 387144

Committed r254234: <https://trac.webkit.org/changeset/254234>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58425712>

[Alexey Proskuryakov]

Why only JavaScriptCore though?

[Keith Miller]

(In reply to Alexey Proskuryakov from comment #6)
> Why only JavaScriptCore though?

IIUC, the other projects' targets don't have their dependences correctly configured to work with parallel builds.

[Saam Barati]

(In reply to Alexey Proskuryakov from comment #6)
> Why only JavaScriptCore though?

JavaScriptCore gets a lot of benefit since we have many test binaries we build after it.

We should enable this for others too, eventually. Just need to go through to see which build targets would benefit

[Saam Barati]

I forgot to mention in the changelog, but this saves 20 seconds of build time on my MBP with 6 cores

[Saam Barati]

Comment on attachment 387144 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387144&action=review

> Source/JavaScriptCore/ChangeLog:4
> +        build-jsc should invoke make instead of calling xcodebuild directly
> +        https://bugs.webkit.org/show_bug.cgi?id=205960

oops, this was the wrong bug :(
Sorry

[Alexey Proskuryakov]

Rolling back in bug 206011, because this broke production builds.

> IIUC, the other projects' targets don't have their dependences correctly configured to work with parallel builds.

In my testing, JavaScriptCore was the only one that wasn't correctly configured. Everything else built fine - although that could be accidental of course.

> Just need to go through to see which build targets would benefit

All of WebKit builds 80 seconds faster on an 18-core iMac Pro with this.

[Saam Barati]

(In reply to Alexey Proskuryakov from comment #11)
> Rolling back in bug 206011, because this broke production builds.
> 
> > IIUC, the other projects' targets don't have their dependences correctly configured to work with parallel builds.
> 
> In my testing, JavaScriptCore was the only one that wasn't correctly
> configured. Everything else built fine - although that could be accidental
> of course.
> 
> > Just need to go through to see which build targets would benefit
> 
> All of WebKit builds 80 seconds faster on an 18-core iMac Pro with this.

Do you know if all of the benefit is inside JavaScriptCore?

[Saam Barati]

This was rolled out because it broke some apple internal build infrastructure

[Saam Barati]

(In reply to Saam Barati from comment #13)
> This was rolled out because it broke some apple internal build infrastructure

It was rolled out in:
https://trac.webkit.org/changeset/254262

[Alexey Proskuryakov]

> Do you know if all of the benefit is inside JavaScriptCore?

I do not know for sure, but my expectation is that it's in other projects too.