Bug 205960 - build-jsc should invoke make instead of calling xcodebuild directly
Summary: build-jsc should invoke make instead of calling xcodebuild directly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on: 206011
Blocks:
  Show dependency tree / graph
 
Reported: 2020-01-08 14:42 PST by Saam Barati
Modified: 2020-01-09 08:46 PST (History)
14 users (show)

See Also:

Attachments
patch (6.55 KB, patch)
2020-01-08 17:17 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-01-08 14:42:39 PST 
...
Comment 1 Saam Barati 2020-01-08 17:17:59 PST 
Created attachment 387166 [details]
patch
Comment 2 Keith Miller 2020-01-08 17:22:52 PST 
Comment on attachment 387166 [details]
patch

r=me.
Comment 3 WebKit Commit Bot 2020-01-08 18:33:51 PST 
Comment on attachment 387166 [details]
patch

Clearing flags on attachment: 387166

Committed r254248: <https://trac.webkit.org/changeset/254248>
Comment 4 WebKit Commit Bot 2020-01-08 18:33:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-01-08 18:34:18 PST 
<rdar://problem/58429911>
Comment 6 WebKit Commit Bot 2020-01-09 08:43:59 PST 
Re-opened since this is blocked by bug 206011
Comment 7 Alexey Proskuryakov 2020-01-09 08:46:09 PST 
This is not being rolled back. The change just had an incorrect ChangeLog.