Bug 205908 - canvas-createImageBitmap-video-resize.html fails after importing /media/ on GTK platform
Summary: canvas-createImageBitmap-video-resize.html fails after importing /media/ on G...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: cathiechen
URL:
Keywords: InRadar
Depends on:
Blocks: 205678
  Show dependency tree / graph
 
Reported: 2020-01-08 00:10 PST by cathiechen
Modified: 2020-01-11 09:33 PST (History)
11 users (show)

See Also:

Attachments
Patch (1.35 KB, patch)
2020-01-08 00:20 PST, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (15.99 KB, patch)
2020-01-09 06:43 PST, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (19.28 KB, patch)
2020-01-10 03:11 PST, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (19.29 KB, patch)
2020-01-10 06:38 PST, cathiechen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description cathiechen 2020-01-08 00:10:19 PST 
canvas-createImageBitmap-video-resize.html has a video element with /media/video.ogv.
It generated a timeout error if /media/video.ogv is not imported.
After importing /media/video.ogv, WebKitGTK support .ogv, so it can pass the test.
For the platforms not supporting .ogv, it will also get a timeout error.
Comment 1 cathiechen 2020-01-08 00:20:14 PST 
Created attachment 387084 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2020-01-08 00:50:49 PST 
Maybe doing something like other tests do could make this pass in Mac too:
  video.src = '../resources/video.' + (video.canPlayType('video/ogg') ? 'ogv' : 'mp4';

Dunno really. I don't know what's the best approach here, if we should just skip this test for Mac or try something like the previous line (even when video.mp4 doesn't exist on that folder I guess we could use test.mp4, dunno if using video.ogv instead of test.ogv is relevant for the test).
Comment 3 cathiechen 2020-01-08 06:32:11 PST 
Comment on attachment 387084 [details]
Patch

Thanks rego! I'm agree with you.

FYI, we are trying to make this test compatible. https://github.com/web-platform-tests/wpt/pull/21084
Comment 4 cathiechen 2020-01-09 06:43:02 PST 
Created attachment 387219 [details]
Patch
Comment 5 cathiechen 2020-01-10 03:11:29 PST 
Created attachment 387323 [details]
Patch
Comment 6 cathiechen 2020-01-10 04:40:45 PST 
Comment on attachment 387323 [details]
Patch

Hi,
This patch is ready to review. PTAL, thanks:)
Comment 7 Manuel Rego Casasnovas 2020-01-10 04:49:02 PST 
Comment on attachment 387323 [details]
Patch

r=me Thanks for taking care of fixing this in WPT.
Please wait for EWSs before landing.
Comment 8 cathiechen 2020-01-10 06:38:59 PST 
Created attachment 387335 [details]
Patch
Comment 9 cathiechen 2020-01-11 08:39:54 PST 
accessibility/mac/select-text/select-text-1.html fails on mac-debug-wk1.
It is not related to this patch.
Comment 10 WebKit Commit Bot 2020-01-11 09:31:17 PST 
The commit-queue encountered the following flaky tests while processing attachment 387335 [details]:

inspector/runtime/executionContextCreated-onEnable.html bug 206130 (author: yurys@chromium.org)
The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2020-01-11 09:32:07 PST 
Comment on attachment 387335 [details]
Patch

Clearing flags on attachment: 387335

Committed r254399: <https://trac.webkit.org/changeset/254399>
Comment 12 WebKit Commit Bot 2020-01-11 09:32:08 PST 
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2020-01-11 09:33:15 PST 
<rdar://problem/58504598>