Bug 205908 – canvas-createImageBitmap-video-resize.html fails after importing /media/ on GTK platform

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[cathiechen]

canvas-createImageBitmap-video-resize.html has a video element with /media/video.ogv.
It generated a timeout error if /media/video.ogv is not imported.
After importing /media/video.ogv, WebKitGTK support .ogv, so it can pass the test.
For the platforms not supporting .ogv, it will also get a timeout error.

[cathiechen]

Created attachment 387084 [details]
Patch

[Manuel Rego Casasnovas]

Maybe doing something like other tests do could make this pass in Mac too:
  video.src = '../resources/video.' + (video.canPlayType('video/ogg') ? 'ogv' : 'mp4';

Dunno really. I don't know what's the best approach here, if we should just skip this test for Mac or try something like the previous line (even when video.mp4 doesn't exist on that folder I guess we could use test.mp4, dunno if using video.ogv instead of test.ogv is relevant for the test).

[cathiechen]

Comment on attachment 387084 [details]
Patch

Thanks rego! I'm agree with you.

FYI, we are trying to make this test compatible. https://github.com/web-platform-tests/wpt/pull/21084

[cathiechen]

Created attachment 387219 [details]
Patch

[cathiechen]

Created attachment 387323 [details]
Patch

[cathiechen]

Comment on attachment 387323 [details]
Patch

Hi,
This patch is ready to review. PTAL, thanks:)

[Manuel Rego Casasnovas]

Comment on attachment 387323 [details]
Patch

r=me Thanks for taking care of fixing this in WPT.
Please wait for EWSs before landing.

[cathiechen]

Created attachment 387335 [details]
Patch

[cathiechen]

accessibility/mac/select-text/select-text-1.html fails on mac-debug-wk1.
It is not related to this patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 387335 [details]:

inspector/runtime/executionContextCreated-onEnable.html bug 206130 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 387335 [details]
Patch

Clearing flags on attachment: 387335

Committed r254399: <https://trac.webkit.org/changeset/254399>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58504598>