Import test cases from web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images
Created attachment 386596 [details]
This patch import test cases for image aspect-ratio generated from attributes width and height.
Created attachment 386597 [details]
Comment on attachment 386597 [details]
LGTM, please wait for EWSs before landing.
Created attachment 386599 [details]
Created attachment 386600 [details]
(In reply to Manuel Rego Casasnovas from comment #4)
> Comment on attachment 386597 [details]
> LGTM, please wait for EWSs before landing.
Comment on attachment 386600 [details]
Clearing flags on attachment: 386600
Committed r253996: <https://trac.webkit.org/changeset/253996>
All reviewed patches have been landed. Closing bug.
Import broke a test on GTK:
(In reply to Jonathan Bedard from comment #11)
> Import broke a test on GTK:
That test is actually passing now in GTK, but it needs an updated -expected.txt result.
That test is using "/media/video.ogv" which was not imported before, so it's expected that there's a change of behavior.
However it seems to be failing yet on other platforms, clord@ could you check what's going on? Thanks!
I tested it on Mac. It seems .ogv file is not supported, so `video.oncanplaythrough` wouldn't fire and it will get an timeout error.
And .ogv is supported by WebKitGTK, so this test passes on GTK.