WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
205678
Import WPT test cases for apect-ratio generated from attribute width and height
https://bugs.webkit.org/show_bug.cgi?id=205678
Summary
Import WPT test cases for apect-ratio generated from attribute width and height
cathiechen
Reported
2020-01-01 19:46:15 PST
Import test cases from web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images
Attachments
Patch
(17.52 KB, patch)
2020-01-01 21:02 PST
,
cathiechen
no flags
Details
Formatted Diff
Diff
Patch
(1.03 MB, patch)
2020-01-01 23:39 PST
,
cathiechen
no flags
Details
Formatted Diff
Diff
Patch
(1.03 MB, patch)
2020-01-02 02:20 PST
,
cathiechen
no flags
Details
Formatted Diff
Diff
Patch
(1.03 MB, patch)
2020-01-02 03:03 PST
,
cathiechen
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
cathiechen
Comment 1
2020-01-01 21:02:15 PST
Created
attachment 386596
[details]
Patch
cathiechen
Comment 2
2020-01-01 21:14:36 PST
Hi, This patch import test cases for image aspect-ratio generated from attributes width and height. PTAL, thanks:)
cathiechen
Comment 3
2020-01-01 23:39:39 PST
Created
attachment 386597
[details]
Patch
Manuel Rego Casasnovas
Comment 4
2020-01-02 00:38:05 PST
Comment on
attachment 386597
[details]
Patch LGTM, please wait for EWSs before landing.
cathiechen
Comment 5
2020-01-02 02:20:23 PST
Created
attachment 386599
[details]
Patch
cathiechen
Comment 6
2020-01-02 03:03:08 PST
Created
attachment 386600
[details]
Patch
cathiechen
Comment 7
2020-01-03 05:45:33 PST
(In reply to Manuel Rego Casasnovas from
comment #4
)
> Comment on
attachment 386597
[details]
> Patch > > LGTM, please wait for EWSs before landing.
Done! Thanks:)
WebKit Commit Bot
Comment 8
2020-01-03 06:18:20 PST
Comment on
attachment 386600
[details]
Patch Clearing flags on attachment: 386600 Committed
r253996
: <
https://trac.webkit.org/changeset/253996
>
WebKit Commit Bot
Comment 9
2020-01-03 06:18:21 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10
2020-01-03 06:19:28 PST
<
rdar://problem/58296773
>
Jonathan Bedard
Comment 11
2020-01-07 15:17:08 PST
Import broke a test on GTK:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2F2dcontext%2Fimagebitmap%2Fcanvas-createImageBitmap-video-resize.html
Manuel Rego Casasnovas
Comment 12
2020-01-07 21:47:45 PST
(In reply to Jonathan Bedard from
comment #11
)
> Import broke a test on GTK: >
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb
- > platform-tests%2F2dcontext%2Fimagebitmap%2Fcanvas-createImageBitmap-video- > resize.html
That test is actually passing now in GTK, but it needs an updated -expected.txt result. That test is using "/media/video.ogv" which was not imported before, so it's expected that there's a change of behavior. However it seems to be failing yet on other platforms, clord@ could you check what's going on? Thanks!
cathiechen
Comment 13
2020-01-07 23:25:11 PST
I tested it on Mac. It seems .ogv file is not supported, so `video.oncanplaythrough` wouldn't fire and it will get an timeout error. And .ogv is supported by WebKitGTK, so this test passes on GTK.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug