Bug 205854 – [GTK][WPE] Gardening for unexpected passes

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Diego Pino]

[GTK][WPE] Gardening for unexpected passes

[Diego Pino]

Created attachment 386959 [details]
Patch

[Diego Pino]

WPE stdio for r254113 (https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Tests%29/builds/16629/steps/layout-test/logs/stdio):

Expected to crash, but passed: (2)

  * editing/async-clipboard/clipboard-do-not-read-text-from-platform-if-text-changes.html: Fixed in r253743.
  * imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey.https.html: Fixed in r253748.

Expected to timeout, but passed: (1)

  * media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html: Fixed in r253367.

Expected to fail, but passed: (29)
  * css3/color-filters/color-filter-opacity.html: Fixed in r252598.
  * fast/canvas/drawImage-with-negative-source-destination.html: Fixed in r253675.
  * http/tests/cache/disk-cache/disk-cache-disable.html: Fixed in r252259.
  * imported/w3c/web-platform-tests/cors/304.htm: Fixed in r253331.
  * imported/w3c/web-platform-tests/cors/cors-safelisted-request-header.any.html: Fixed in r253331.
  * imported/w3c/web-platform-tests/cors/redirect-preflight-2.htm: Fixed in r253331.
  * imported/w3c/web-platform-tests/cors/simple-requests.htm: Fixed in r253331.
  * imported/w3c/web-platform-tests/css/css-images/multiple-position-color-stop-conic.html:  Fixed in r253685.
  * imported/w3c/web-platform-tests/css/css-shapes/shape-outside/values/shape-margin-001.html: Fixed in r252370.
  * imported/w3c/web-platform-tests/css/css-shapes/shape-outside/values/shape-outside-shape-arguments-000.html: Fixed in r252370.
  * imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/select-sizing-001.html: Fixed in r253791.
  * imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/sizes-dynamic-001.html: Fixed in r252828.
  * imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/sizes-dynamic-002.html: Fixed in r252828:
  * imported/w3c/web-platform-tests/offscreen-canvas/filter/offscreencanvas.filter.w.html: Fixed in r253099.
  * imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html: Fixed in r253331.
  * imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-css-images.https.html: Fixed in r253331.
  * imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-resources.https.html: Fixed in r253331.
  * imported/w3c/web-platform-tests/service-workers/service-worker/fetch-response-taint.https.html: Fixed in r253331.
  * imported/w3c/web-platform-tests/websockets/cookies/002.html: Fixed in r253331.
  * imported/w3c/web-platform-tests/xhr/access-control-preflight-async-header-denied.htm: Fixed in r253331.
  * imported/w3c/web-platform-tests/xhr/access-control-preflight-async-method-denied.htm: Fixed in r253331.
  * imported/w3c/web-platform-tests/xhr/access-control-preflight-async-not-supported.htm: Fixed in r253331.
  * imported/w3c/web-platform-tests/xhr/access-control-preflight-sync-header-denied.htm: Fixed in r253331.
  * imported/w3c/web-platform-tests/xhr/access-control-preflight-sync-method-denied.htm: Fixed in r253331.
  * imported/w3c/web-platform-tests/xhr/access-control-preflight-sync-not-supported.htm: Fixed in r253331.
  * imported/w3c/web-platform-tests/xhr/send-conditional-cors.htm: Fixed in r253331.
  * webgl/1.0.3/conformance/extensions/get-extension.html: Fixed in r253919.
  * webgl/1.0.3/conformance/renderbuffers/framebuffer-object-attachment.html: Fixed in r253918. 
  * webgl/2.0.0/conformance2/glsl3/ .html: Fixed in r254014.

[Diego Pino]

  * webgl/2.0.0/conformance2/glsl3/no-attribute-vertex-shader.html: Fixed in r254014.

[Diego Pino]

After this patch has landed, it might be possible to close the following bugs:

  * webkit.org/b/163974: Fixed by r253675.
  * webkit.org/b/204670: Partially fixed by r253367. Should confirm whether media/encrypted-media/clearKey/clearKey-webm-video-playback-mse.html is passing on GTK.
  * webkit.org/b/153709: Fixed by r252259.
  * webkit.org/b/179608: Fixed by r253331.
  * webkit.org/b/202512: Fixed by r253748. Among all the tests listed in the bug ticket the only remaining in TestExpectations was imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey.https.html (removed in this patch), so the bug can be closed.

[Diego Pino]

Created attachment 387009 [details]
Patch

[Diego Pino]

Created attachment 387010 [details]
Patch

[Diego Pino]

Created attachment 387025 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 387025 [details]
Patch

Rejecting attachment 387025 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 387025, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13301124

[Diego Pino]

Created attachment 387097 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 387097 [details]
Patch

Clearing flags on attachment: 387097

Committed r254203: <https://trac.webkit.org/changeset/254203>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58409983>