http/tests/cache/disk-cache/disk-cache-disable.html is failing since r188211: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/cache/disk-cache/disk-cache-disable-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/cache/disk-cache/disk-cache-disable-actual.txt @@ -23,11 +23,11 @@ --------Testing loads through memory cache (XHR behavior)-------- response headers: {"Cache-control":"max-age=100"} -response source: Memory cache +response source: Network --------Testing loads through memory cache (subresource behavior)-------- response headers: {"Cache-control":"max-age=100"} -response source: Memory cache +response source: Network Re-enabling cache --------Testing loads from disk cache--------
I can't reproduce this locally.
I'm stupid, I didn't notice there was already an expectation for this, so it failed for me, as expected :-D
Antti, Chris I think the bug is actually in Mac, and our results are the correct ones. The thing is that we disable also the memory cache when cache model is document viewer, but cocoa implementation doesn't. If that's the desired behavior in Mac, we can simply add our own expectations for this test.
Could someone confirm if document viewer cache model is expected to disable also the memory cache in mac?
I think Geoff’s the right person to answer that question. Might take him a little time to research and refresh his memory, though.
Gently ping about this one.
Hey Geoff, if you read this, there's a question for you up above.
According to https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/11947/steps/layout-test/logs/stdio this test passes. Will update expectations.