Bug 153709 - [GTK] http/tests/cache/disk-cache/disk-cache-disable.html is failing
Summary: [GTK] http/tests/cache/disk-cache/disk-cache-disable.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-30 09:00 PST by Michael Catanzaro
Modified: 2019-11-27 04:19 PST (History)
9 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-01-30 09:00:54 PST
http/tests/cache/disk-cache/disk-cache-disable.html is failing since r188211:

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/cache/disk-cache/disk-cache-disable-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/cache/disk-cache/disk-cache-disable-actual.txt
@@ -23,11 +23,11 @@
 
 --------Testing loads through memory cache (XHR behavior)--------
 response headers: {"Cache-control":"max-age=100"}
-response source: Memory cache
+response source: Network
 
 --------Testing loads through memory cache (subresource behavior)--------
 response headers: {"Cache-control":"max-age=100"}
-response source: Memory cache
+response source: Network
 
 Re-enabling cache
 --------Testing loads from disk cache--------
Comment 1 Carlos Garcia Campos 2016-02-02 04:42:30 PST
I can't reproduce this locally.
Comment 2 Carlos Garcia Campos 2016-02-03 03:18:59 PST
I'm stupid, I didn't notice there was already an expectation for this, so it failed for me, as expected :-D
Comment 3 Carlos Garcia Campos 2016-02-03 04:11:27 PST
Antti, Chris I think the bug is actually in Mac, and our results are the correct ones. The thing is that we disable also the memory cache when cache model is document viewer, but cocoa implementation doesn't. If that's the desired behavior in Mac, we can simply add our own expectations for this test.
Comment 4 Carlos Garcia Campos 2016-02-11 01:10:17 PST
Could someone confirm if document viewer cache model is expected to disable also the memory cache in mac?
Comment 5 Darin Adler 2016-02-11 09:29:01 PST
I think Geoff’s the right person to answer that question. Might take him a little time to research and refresh his memory, though.
Comment 6 Claudio Saavedra 2017-06-22 05:49:54 PDT
Gently ping about this one.
Comment 7 Michael Catanzaro 2017-06-23 16:52:54 PDT
Hey Geoff, if you read this, there's a question for you up above.
Comment 8 Nikolas Zimmermann 2019-11-27 04:19:06 PST
According to https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/11947/steps/layout-test/logs/stdio this test passes. Will update expectations.