Re-sync web-platform-tests/common from upstream.
Created attachment 385895 [details] WIP Patch
Created attachment 385908 [details] WIP Patch
Created attachment 385917 [details] WIP Patch
Created attachment 385933 [details] Patch
Created attachment 385935 [details] Patch
Comment on attachment 385935 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385935&action=review > LayoutTests/canvas/philip/tests/2d.drawImage.incomplete.emptysrc.html:7 > +<link rel="stylesheet" href="../../../imported/w3c/web-platform-tests/2dcontext/resources/canvas-tests.css"> I noticed that these tests currently rely on imported/w3c/web-platform-tests resources. Although your patch does not change the situation, I think there has been some controversy in the past when relying on WPT (bug 179769) so it might be worth checking with your colleagues.
Comment on attachment 385935 [details] Patch Clearing flags on attachment: 385935 Committed r253683: <https://trac.webkit.org/changeset/253683>
All reviewed patches have been landed. Closing bug.
<rdar://problem/58042926>
This commit has broken all offscreen-canvas tests, which used the canvas-related files in LayoutTests/imported/w3c/web-platform-tests/common/ that were deleted by this patch. I guess updating the affected tests will fix this(?)
(In reply to Chris Lord from comment #10) > This commit has broken all offscreen-canvas tests, which used the > canvas-related files in LayoutTests/imported/w3c/web-platform-tests/common/ > that were deleted by this patch. I guess updating the affected tests will > fix this(?) Yeah I had concern about this change in comment 6. Maybe as a quick solution you can upload a patch to put back the deleted file? Or otherwise as I you suggested, update the affected tests.
(In reply to Chris Lord from comment #10) > This commit has broken all offscreen-canvas tests, which used the > canvas-related files in LayoutTests/imported/w3c/web-platform-tests/common/ > that were deleted by this patch. I guess updating the affected tests will > fix this(?) I will mark all those tests to bug 205445
I think we should resync the offscreen-canvas tests then.
(In reply to Chris Dumez from comment #13) > I think we should resync the offscreen-canvas tests then. Doing so in bug 205445.
(In reply to Chris Lord from comment #14) > (In reply to Chris Dumez from comment #13) > > I think we should resync the offscreen-canvas tests then. > > Doing so in bug 205445. Thanks. I am guessing those tests are skipped on Apple platforms and that’s why I missed them, sorry about that.