WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
179769
Import 2dcontext/the-canvas-state/ from wpt.
https://bugs.webkit.org/show_bug.cgi?id=179769
Summary
Import 2dcontext/the-canvas-state/ from wpt.
Ms2ger (he/him; ⌚ UTC+1/+2)
Reported
2017-11-16 08:08:34 PST
.
Attachments
Patch
(160.89 KB, patch)
2017-11-16 08:34 PST
,
Ms2ger (he/him; ⌚ UTC+1/+2)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 1
2017-11-16 08:34:20 PST
Created
attachment 327064
[details]
Patch
youenn fablet
Comment 2
2017-11-16 08:59:39 PST
Comment on
attachment 327064
[details]
Patch Nice!
WebKit Commit Bot
Comment 3
2017-11-16 09:30:08 PST
Comment on
attachment 327064
[details]
Patch Clearing flags on attachment: 327064 Committed
r224921
: <
https://trac.webkit.org/changeset/224921
>
WebKit Commit Bot
Comment 4
2017-11-16 09:30:09 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5
2017-11-16 09:31:29 PST
<
rdar://problem/35590236
>
Alexey Proskuryakov
Comment 6
2017-11-16 22:08:29 PST
We shouldn't be doing this. These tests are primarily useful when shared with other teams, so requiring a complicated harness to run them is unacceptable.
WebKit Commit Bot
Comment 7
2017-11-16 22:09:22 PST
Re-opened since this is blocked by
bug 179813
youenn fablet
Comment 8
2017-11-16 22:15:46 PST
Reopening for further discussion.
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 9
2017-11-17 01:18:30 PST
I'm afraid I don't really understand your objection; could you elaborate?
youenn fablet
Comment 10
2017-11-17 09:21:07 PST
Given the discussion in webkit-dev, I think we can proceed with this patch: - removed tests are clearly conformance tests and not regression tests - added tests are slightly better than removed tests and will be kept up to date
Alexey Proskuryakov
Comment 11
2017-11-17 09:40:44 PST
> I'm afraid I don't really understand your objection; could you elaborate?
When there is a problem in graphics frameworks below WebKit, I can easily put the test in a zip archive, and ask the team working on the framework to debug what's going on. They can edit the test locally as they see fit to simplify it as part of their investigation. Requiring a full WebKit checkout and complicated scripts that may or may not even work in their OS build will make getting fixes for such problems substantially trickier.
youenn fablet
Comment 12
2017-11-17 09:58:29 PST
Creating a zip archive is not straightforward either. It still requires to get all the necessary resources available which might be tricky. WPT tests are available at
https://w3c-test.org
.
Alexey Proskuryakov
Comment 13
2017-11-17 10:27:54 PST
One cannot edit the w3c-test.org copy, which is important for debugging.
youenn fablet
Comment 14
2017-11-21 08:37:12 PST
(In reply to Alexey Proskuryakov from
comment #13
)
> One cannot edit the w3c-test.org copy, which is important for debugging.
Is a webarchive somehow hackable? If so, it should be fairly easy and less error-prone than a zip archive to create a webarchive from an existing webpage, send that webarchive and edit it.
youenn fablet
Comment 15
2017-11-21 08:37:39 PST
Given the discussion in webkit-dev, we should probably reland this patch. Please let me know if there is any objection.
Frédéric Wang (:fredw)
Comment 16
2017-11-24 06:31:57 PST
(In reply to youenn fablet from
comment #15
)
> Given the discussion in webkit-dev, we should probably reland this patch. > Please let me know if there is any objection.
@Youenn: I'm not sure which part of the conversation makes you think we should, but as I understand the situation is stalled until we improve runtime performance of WPT tests on WebKit. From my point of view, sharing the tests with the rest of the web platform community (to keep it up-to-date, being able to compare results, etc) is more important than making it convenient for Apple to work internally on proprietary code outside WebKit. I wonder, if maybe we should still import the new tests and let each port maintainers decide which version of the tests they want to skip in TestExpectations?
youenn fablet
Comment 17
2017-11-24 08:32:23 PST
> @Youenn: > > I'm not sure which part of the conversation makes you think we should, but > as I understand the situation is stalled until we improve runtime > performance of WPT tests on WebKit.
From webkit-dev, it seems fine to continue importing WPT tests, including these 2d tests. The main discussion point is whether we should remove the corresponding WebKit tests. Since the existing WebKit 2dcontext tests are not regression tests but conformance tests, I think it is fine to remove them as well.
Alexey Proskuryakov
Comment 18
2017-11-27 11:50:05 PST
> Is a webarchive somehow hackable?
It's not. Definitely not within easy reach of someone who works on lower level frameworks.
> From webkit-dev, it seems fine to continue importing WPT tests, including these 2d tests.
Let's give everyone who just got back from the Thanksgiving holiday (including myself) catch up on the discussion. My feeling is that test stability and performance is more important for WebKit right now than adding more tests. This is obviously a very general statement, we can have lots of special cases.
Frédéric Wang (:fredw)
Comment 19
2019-01-21 06:45:56 PST
@David @Simon: Instead of having 3 separate bugs for this issue, we should probably merge all of them into one. Can we mark
bug 193579
and
bug 193042
as duplicate of this one?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug