Bug 193579 – Duplicate tests between canvas/philip/tests and imported/w3c/canvas

• Status: NEW
• Component: Tools / Tests

[David Kilzer (:ddkilzer)]

There appear to be a large number of duplicate tests between canvas/philip/tests and imported/w3c/canvas in the LayoutTests directory.

Removing the duplicate tests could marginally speed up layout test runs.

[David Kilzer (:ddkilzer)]

The canvas/philip/tests were imported in <https://trac.webkit.org/r59954> on May 14, 2010 long before the W3C test suite existed.

It seems like these tests have been upstreamed to the W3C test suite, but the older copies have not all been removed.

In fact, there appear to be 741 tests that are duplicates by name:

$ ls `find LayoutTests/canvas/philip/tests -name \*.html | sed -e 's#canvas/philip/tests#imported/w3c/canvas#'` 2> /dev/null | wc -l
     741

And there are 34 tests that only exist in canvas/philip/tests:

$ ls `find LayoutTests/canvas/philip/tests -name \*.html | sed -e 's#canvas/philip/tests#imported/w3c/canvas#'` > /dev/null
ls: LayoutTests/imported/w3c/canvas/2d.clearRect+fillRect.alpha0.5.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.clearRect+fillRect.alpha0.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.clearRect+fillRect.basic.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.composite.globalComposite.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.composite.operation.foobar.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.composite.operation.nullsuffix.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.drawImage.incomplete.emptysrc.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.drawImage.incomplete.nosrc.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.drawImage.incomplete.removedsrc.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.drawImage.negativeSourceHeight.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.drawImage.negativeSourceHeight2.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.drawImage.negativeSourceHeightAndWidth.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.drawImage.outsidesource.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.line.cap.invalid.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.line.join.invalid.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.missingargs.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.pattern.image.broken.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.pattern.image.incomplete.emptysrc.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.pattern.image.incomplete.removedsrc.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.pattern.repeat.nullsuffix.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.strokeRect.zero.4.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.text-custom-font-load-crash.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.text.align.invalid.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.text.baseline.invalid.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.text.draw.baseline.bottom.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.text.draw.baseline.hanging.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.text.draw.baseline.ideographic.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.text.draw.baseline.middle.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.text.draw.baseline.top.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.text.draw.space.collapse.end.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.text.draw.space.collapse.other.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.text.draw.space.collapse.space.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.text.draw.space.collapse.start.html: No such file or directory
ls: LayoutTests/imported/w3c/canvas/2d.text.measure.width.space.html: No such file or directory

[David Kilzer (:ddkilzer)]

I noticed this while working on finding leaks in WebKit2 tests, but I don't have time to investigate this right now (other than blindly removing the duplicate canvas/philip/tests--which I did not want to do), so filed this bug to track the issue.

[Simon Fraser (smfr)]

See bug 193042