Bug 205315 – test-lldb-webkit: Run in CI

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

We should run test-lldb-webkit in our continuous integration.

[Jonathan Bedard]

Created attachment 385832 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 385832 [details]
Patch

I think that you also need to add the new step to the list of consequential steps that make the bot watcher’s bubble red. 

Not sure if we have enough code shared for this to run on EWS. Probably not.

[Jonathan Bedard]

(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 385832 [details]
> Patch
> 
> I think that you also need to add the new step to the list of consequential
> steps that make the bot watcher’s bubble red. 
> 
> Not sure if we have enough code shared for this to run on EWS. Probably not.

I did look into EWS. It's a bit more complicated there and I'm not 100% sure the right architecture. It's a tools test, so it seems like it should run in the same way that test-webkitpy does, but it also requires a built binary, so it probably needs to run the same way API tests do. That will likely mean another bubble along with sharing machines with API tests (probably).

I was going to do that in a separate patch, and while I'd like to take a stab at it (because someone other than Aakash needs to understand EWS, and something like this is a great way for me to do that), I really wouldn't feel comfortable landing that change without an r+ from Aakash.

[Jonathan Bedard]

Created attachment 385841 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 385841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385841&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:652
> +    command = [

Reporting results to flakiness dashboard is another missing piece of course.

[Jonathan Bedard]

(In reply to Alexey Proskuryakov from comment #5)
> Comment on attachment 385841 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385841&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/steps.py:652
> > +    command = [
> 
> Reporting results to flakiness dashboard is another missing piece of course.

Yes, not difficult to add in later on, just not sure we actually want reporting here.

[WebKit Commit Bot]

Comment on attachment 385841 [details]
Patch

Clearing flags on attachment: 385841

Committed r253611: <https://trac.webkit.org/changeset/253611>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57997959>

[Jonathan Bedard]

Committed r253729: <https://trac.webkit.org/changeset/253729>