Bug 205271 - lldbwebkittester: Conform with testing binary format
Summary: lldbwebkittester: Conform with testing binary format
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-16 07:32 PST by Jonathan Bedard
Modified: 2019-12-16 16:59 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.89 KB, patch)
2019-12-16 07:35 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (1.76 KB, patch)
2019-12-16 08:55 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (1.94 KB, patch)
2019-12-16 13:39 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-12-16 07:32:38 PST
lldbwebkittester should be built with all our other tooling.
Comment 1 Jonathan Bedard 2019-12-16 07:35:11 PST
Created attachment 385764 [details]
Patch
Comment 2 Jonathan Bedard 2019-12-16 08:55:03 PST
Created attachment 385772 [details]
Patch
Comment 3 Alexey Proskuryakov 2019-12-16 10:54:56 PST
Comment on attachment 385772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385772&action=review

> Tools/ChangeLog:8
> +        lldbwebkittester should be built the same way ImageDiff, TestWebKitAPI and WebKitTestRunner are.

I think that it would be helpful to elaborate more. In addition to consistency, this paves the way to testing lldb scripts against WebCore and WebKit in the future, which would be a non-starter if build-lldbwebkittester was expected to rebuild everything.

> Tools/ChangeLog:11
> +        * Scripts/build-webkit:

Does make build it already? build-webkit should be consistent with make too.
Comment 4 Jonathan Bedard 2019-12-16 11:23:02 PST
Comment on attachment 385772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385772&action=review

>> Tools/ChangeLog:11
>> +        * Scripts/build-webkit:
> 
> Does make build it already? build-webkit should be consistent with make too.

Make does already build it, at least in WebKit. Verifying that this is actually the case now.
Comment 5 Jonathan Bedard 2019-12-16 13:39:55 PST
Created attachment 385804 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-12-16 14:25:00 PST
Comment on attachment 385804 [details]
Patch for landing

Clearing flags on attachment: 385804

Committed r253577: <https://trac.webkit.org/changeset/253577>
Comment 7 WebKit Commit Bot 2019-12-16 14:25:02 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-12-16 14:26:40 PST
<rdar://problem/57985186>