Bug 205293 - Fix btjs on current lldb
Summary: Fix btjs on current lldb
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-16 12:19 PST by Keith Miller
Modified: 2019-12-16 13:51 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.84 KB, patch)
2019-12-16 12:19 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2019-12-16 12:19:34 PST 
Fix btjs on current lldb
Comment 1 Keith Miller 2019-12-16 12:19:53 PST 
Created attachment 385793 [details]
Patch
Comment 2 Mark Lam 2019-12-16 12:22:40 PST 
Comment on attachment 385793 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2019-12-16 12:58:52 PST 
Comment on attachment 385793 [details]
Patch

Clearing flags on attachment: 385793

Committed r253572: <https://trac.webkit.org/changeset/253572>
Comment 4 WebKit Commit Bot 2019-12-16 12:58:53 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-12-16 12:59:18 PST 
<rdar://problem/57981841>
Comment 6 Alexey Proskuryakov 2019-12-16 13:23:06 PST 
We have tests for lldb_webkit, can one be added here?
Comment 7 Keith Miller 2019-12-16 13:30:53 PST 
(In reply to Alexey Proskuryakov from comment #6)
> We have tests for lldb_webkit, can one be added here?

I couldn't figure out how to get the tests to run. Do we run them in automation?
Comment 8 Jonathan Bedard 2019-12-16 13:51:27 PST 
(In reply to Keith Miller from comment #7)
> (In reply to Alexey Proskuryakov from comment #6)
> > We have tests for lldb_webkit, can one be added here?
> 
> I couldn't figure out how to get the tests to run. Do we run them in
> automation?

There is a script, test-lldb-webkit. No, they are not currently run in automation, but that is imminently changing (waiting on https://bugs.webkit.org/show_bug.cgi?id=205271 to land)