Bug 205270 – [GStreamer][WPE] Fix regressions related to our 'Fix GStreamer capturer mock' patch

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Thibault Saunier]

See patch

[Thibault Saunier]

Created attachment 385763 [details]
Patch

[Philippe Normand]

Comment on attachment 385763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385763&action=review

> LayoutTests/webrtc/peer-connection-audio-mute.html:34
> -        return navigator.mediaDevices.getUserMedia({audio: true}).then((localStream) => {
> +        return navigator.mediaDevices.getUserMedia({audio: { echoCancellation : false}}).then((localStream) => {

Why this change?

[Thibault Saunier]

(In reply to Philippe Normand from comment #2)
> Comment on attachment 385763 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385763&action=review
> 
> > LayoutTests/webrtc/peer-connection-audio-mute.html:34
> > -        return navigator.mediaDevices.getUserMedia({audio: true}).then((localStream) => {
> > +        return navigator.mediaDevices.getUserMedia({audio: { echoCancellation : false}}).then((localStream) => {
> 
> Why this change?

Because the test expects no echo cancelation and apple ports mock default to echoCancellation=false but this is not correct. see https://bugs.webkit.org/show_bug.cgi?id=205057

[WebKit Commit Bot]

Comment on attachment 385763 [details]
Patch

Clearing flags on attachment: 385763

Committed r253617: <https://trac.webkit.org/changeset/253617>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58001072>