RESOLVED FIXED 205057
MediaStreamTrack-getSettings wrongly expects default echoCancellation to be false 
https://bugs.webkit.org/show_bug.cgi?id=205057
Summary MediaStreamTrack-getSettings wrongly expects default echoCancellation to be f...
Thibault Saunier
Reported 2019-12-10 04:10:44 PST
In MediaStreamTrack-getSettings.html[0] we getUserMedia without any audio constraint, but we expect `settings.echoCancellation = false` in MediaStreamTrack-getSettings-expected.txt[1] the specs states that "echoCancellation of type boolean, defaulting to true "[2]. I think this is a bug in the mock, more specifically in Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm[3] but the issue doesn't actually exist outside the mock. [0] https://trac.webkit.org/browser/webkit/trunk/LayoutTests/fast/mediastream/MediaStreamTrack-getSettings.html [1] https://trac.webkit.org/browser/webkit/trunk/LayoutTests/fast/mediastream/MediaStreamTrack-getSettings-expected.txt#L15 [2] https://w3c.github.io/mediacapture-main/#widl-MediaTrackSettings-echoCancellation [3] https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm#L112
Attachments
Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2020-03-11 23:23:37 PDT
Fixed by r258255.
Radar WebKit Bug Importer
Comment 2 2020-03-11 23:24:17 PDT
<rdar://problem/60358527>
Note You need to log in before you can comment on or make changes to this bug.