Bug 205164 - REGRESSION: (r251677) imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-3.html is a flaky failure
Summary: REGRESSION: (r251677) imported/w3c/web-platform-tests/html/semantics/forms/fo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
: 203609 204800 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-12-12 08:57 PST by Truitt Savell
Modified: 2019-12-19 16:29 PST (History)
14 users (show)

See Also:

Attachments
Patch (9.27 KB, patch)
2019-12-13 11:50 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (13.74 KB, patch)
2019-12-19 12:01 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (14.37 KB, patch)
2019-12-19 12:37 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2019-12-12 08:57:35 PST 
The new test imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-3.html

is a flakey failure https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Fforms%2Fform-submission-0%2Fform-double-submit-3.html on all Mac 

Diff:
--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-3-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-3-actual.txt
@@ -4,5 +4,5 @@
 
 submit
 
-FAIL <button> should have the same double-submit protection as <input type=submit> assert_unreached: Frame1 should not get navigated by this test. Reached unreachable code
+PASS <button> should have the same double-submit protection as <input type=submit>
Comment 1 Radar WebKit Bug Importer 2019-12-12 08:58:13 PST 
<rdar://problem/57879042>
Comment 2 Truitt Savell 2019-12-12 08:58:31 PST 
Test was added in https://trac.webkit.org/changeset/251677/webkit
Comment 3 Truitt Savell 2019-12-12 09:26:10 PST 
Marked test as failing while investigating: https://trac.webkit.org/changeset/253429/webkit
Comment 4 Chris Dumez 2019-12-13 11:50:59 PST 
Created attachment 385623 [details]
Patch
Comment 5 Alex Christensen 2019-12-13 12:34:06 PST 
Comment on attachment 385623 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385623&action=review

> LayoutTests/ChangeLog:9
> +        Unskip test that should no longer be flaky.

You have inconsistent spelling of "flaky" in this change log.
Comment 6 Chris Dumez 2019-12-13 12:34:57 PST 
(In reply to Alex Christensen from comment #5)
> Comment on attachment 385623 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385623&action=review
> 
> > LayoutTests/ChangeLog:9
> > +        Unskip test that should no longer be flaky.
> 
> You have inconsistent spelling of "flaky" in this change log.

Because the bug title was not written by me. Which one is right? :)
Comment 7 Chris Dumez 2019-12-13 12:36:13 PST 
I'm going to go with "flaky".
Comment 8 Chris Dumez 2019-12-13 12:38:18 PST 
Committed r253493: <https://trac.webkit.org/changeset/253493>
Comment 9 Alexey Proskuryakov 2019-12-16 14:05:59 PST 
*** Bug 203609 has been marked as a duplicate of this bug. ***
Comment 10 Alexey Proskuryakov 2019-12-16 14:06:25 PST 
*** Bug 204800 has been marked as a duplicate of this bug. ***
Comment 11 Chris Dumez 2019-12-17 18:32:32 PST 
Reverted in <https://trac.webkit.org/changeset/253666>.
Comment 12 Chris Dumez 2019-12-19 12:01:12 PST 
Created attachment 386129 [details]
Patch
Comment 13 Chris Dumez 2019-12-19 12:37:01 PST 
Created attachment 386133 [details]
Patch
Comment 14 WebKit Commit Bot 2019-12-19 16:29:05 PST 
Comment on attachment 386133 [details]
Patch

Clearing flags on attachment: 386133

Committed r253799: <https://trac.webkit.org/changeset/253799>
Comment 15 WebKit Commit Bot 2019-12-19 16:29:07 PST 
All reviewed patches have been landed.  Closing bug.