Bug 205007 – Add an option to capture audio in GPU process

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Add an option to capture audio in GPU process

[youenn fablet]

Created attachment 385144 [details]
Patch

[Eric Carlson]

Comment on attachment 385144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385144&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1701
> +CaptureAudioInGPUProcessEnabled:
> +  type: bool
> +  defaultValue: false
> +  humanReadableName: "Capture audio in GPUProcess"
> +  humanReadableDescription: "Capture audio in GPUProcess"
> +  category: experimental
> +  webcoreBinding: none
> +  condition: ENABLE(MEDIA_STREAM)

See Tim's comment in https://bugs.webkit.org/show_bug.cgi?id=204801 - this should be an internal feature and should have a name like "useGPUProcessForAudioCapture".

[youenn fablet]

(In reply to Eric Carlson from comment #2)
> Comment on attachment 385144 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385144&action=review
> 
> > Source/WebKit/Shared/WebPreferences.yaml:1701
> > +CaptureAudioInGPUProcessEnabled:
> > +  type: bool
> > +  defaultValue: false
> > +  humanReadableName: "Capture audio in GPUProcess"
> > +  humanReadableDescription: "Capture audio in GPUProcess"
> > +  category: experimental
> > +  webcoreBinding: none
> > +  condition: ENABLE(MEDIA_STREAM)
> 
> See Tim's comment in https://bugs.webkit.org/show_bug.cgi?id=204801 - this
> should be an internal feature and should have a name like
> "useGPUProcessForAudioCapture".

OK for internals for now.
I think it should not take too long to allow audio capture in GPUProcess so that might be a good candidate for STP soon.

As of the naming, we already have CaptureAudioInUIProcess so I prefer keeping CaptureAudioInGPUProcess. It also seems easy to read.

[youenn fablet]

Created attachment 385147 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 385147 [details]
Patch

Clearing flags on attachment: 385147

Committed r253288: <https://trac.webkit.org/changeset/253288>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57751825>