Bug 205007 - Add an option to capture audio in GPU process
Summary: Add an option to capture audio in GPU process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-09 05:19 PST by youenn fablet
Modified: 2019-12-09 07:37 PST (History)
12 users (show)

See Also:

Attachments
Patch (26.11 KB, patch)
2019-12-09 05:25 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (26.11 KB, patch)
2019-12-09 06:10 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-12-09 05:19:21 PST 
Add an option to capture audio in GPU process
Comment 1 youenn fablet 2019-12-09 05:25:23 PST 
Created attachment 385144 [details]
Patch
Comment 2 Eric Carlson 2019-12-09 06:04:25 PST 
Comment on attachment 385144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385144&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1701
> +CaptureAudioInGPUProcessEnabled:
> +  type: bool
> +  defaultValue: false
> +  humanReadableName: "Capture audio in GPUProcess"
> +  humanReadableDescription: "Capture audio in GPUProcess"
> +  category: experimental
> +  webcoreBinding: none
> +  condition: ENABLE(MEDIA_STREAM)

See Tim's comment in https://bugs.webkit.org/show_bug.cgi?id=204801 - this should be an internal feature and should have a name like "useGPUProcessForAudioCapture".
Comment 3 youenn fablet 2019-12-09 06:09:15 PST 
(In reply to Eric Carlson from comment #2)
> Comment on attachment 385144 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385144&action=review
> 
> > Source/WebKit/Shared/WebPreferences.yaml:1701
> > +CaptureAudioInGPUProcessEnabled:
> > +  type: bool
> > +  defaultValue: false
> > +  humanReadableName: "Capture audio in GPUProcess"
> > +  humanReadableDescription: "Capture audio in GPUProcess"
> > +  category: experimental
> > +  webcoreBinding: none
> > +  condition: ENABLE(MEDIA_STREAM)
> 
> See Tim's comment in https://bugs.webkit.org/show_bug.cgi?id=204801 - this
> should be an internal feature and should have a name like
> "useGPUProcessForAudioCapture".

OK for internals for now.
I think it should not take too long to allow audio capture in GPUProcess so that might be a good candidate for STP soon.

As of the naming, we already have CaptureAudioInUIProcess so I prefer keeping CaptureAudioInGPUProcess. It also seems easy to read.
Comment 4 youenn fablet 2019-12-09 06:10:35 PST 
Created attachment 385147 [details]
Patch
Comment 5 WebKit Commit Bot 2019-12-09 07:36:49 PST 
Comment on attachment 385147 [details]
Patch

Clearing flags on attachment: 385147

Committed r253288: <https://trac.webkit.org/changeset/253288>
Comment 6 WebKit Commit Bot 2019-12-09 07:36:51 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-12-09 07:37:43 PST 
<rdar://problem/57751825>