Bug 204801 - Add a runtime setting for media in the GPU process
Summary: Add a runtime setting for media in the GPU process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-03 11:12 PST by Eric Carlson
Modified: 2019-12-08 22:07 PST (History)
9 users (show)

See Also:

Attachments
Patch (8.35 KB, patch)
2019-12-03 11:21 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing (8.42 KB, patch)
2019-12-03 13:43 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2019-12-03 11:12:43 PST 
Add a runtime setting for media in the GPU process
Comment 1 Radar WebKit Bug Importer 2019-12-03 11:13:03 PST 
<rdar://problem/57596199>
Comment 2 Eric Carlson 2019-12-03 11:21:04 PST 
Created attachment 384727 [details]
Patch
Comment 3 Jer Noble 2019-12-03 13:26:52 PST 
Comment on attachment 384727 [details]
Patch

r=me with nit: could we rename the preference "outOfProcessMediaEnabled"?
Comment 4 Eric Carlson 2019-12-03 13:43:48 PST 
Created attachment 384753 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-12-03 14:56:54 PST 
Comment on attachment 384753 [details]
Patch for landing

Clearing flags on attachment: 384753

Committed r253063: <https://trac.webkit.org/changeset/253063>
Comment 6 WebKit Commit Bot 2019-12-03 14:56:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Tim Horton 2019-12-08 22:07:16 PST 
Comment on attachment 384753 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=384753&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1832
> +OutOfProcessMediaEnabled:

I would have preferred something like "useGPUProcessForMedia". "Out of process" is so vague and is already true regardless, and "useGPUProcessForX" is easy to follow for the canvas, WebGL, and page-painting cases.

> Source/WebKit/Shared/WebPreferences.yaml:1838
> +    category: experimental

This should be an "internal" feature, not experimental. Definitely not ready for this to show up in STP