It appears to exist purely to avoid rebasing test results.
Created attachment 385138 [details] wip
Created attachment 385245 [details] wip
Created attachment 385251 [details] patch
Created attachment 385252 [details] patch
Comment on attachment 385252 [details] patch Let's see what it breaks.
Bot watchers: if this affects results in other bots it can be dealt by rebasing.
Comment on attachment 385252 [details] patch Rejecting attachment 385252 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 385252, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: /platform/mac/fast/text/svg-font-face-with-kerning-expected.txt patching file LayoutTests/platform/mac/fast/writing-mode/border-styles-vertical-lr-expected.txt patching file LayoutTests/platform/mac/fast/writing-mode/english-bt-text-expected.txt patching file LayoutTests/platform/mac/fast/writing-mode/text-orientation-basic-expected.txt patching file LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug56024-expected.txt patching file LayoutTests/platform/win/fast/text/international/bidi-layout-across-linebreak-expected.txt patching file LayoutTests/platform/win/fast/writing-mode/english-bt-text-expected.txt patching file LayoutTests/platform/win/fast/writing-mode/text-orientation-basic-expected.txt patching file LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug56024-expected.txt patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/InlineBox.cpp patching file Source/WebCore/rendering/RenderLineBreak.cpp patching file Source/WebCore/rendering/RenderLineBreak.h patching file Source/WebCore/rendering/RenderTreeAsText.cpp patching file Source/WebCore/rendering/SimpleLineLayoutResolver.cpp patching file Source/WebCore/rendering/SimpleLineLayoutResolver.h patching file Source/WebCore/rendering/line/LineLayoutTraversal.h patching file Source/WebCore/rendering/line/LineLayoutTraversalComplexPath.h patching file Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h Hunk #1 FAILED at 58. 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h.rej patching file Source/WebCore/rendering/line/LineLayoutTraversalSimplePath.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Zalan Bujtas']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 28 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/multicol/pagination-h-horizontal-bt-expected.txt patching file LayoutTests/fast/multicol/pagination-v-horizontal-bt-expected.txt patching file LayoutTests/fast/ruby/position-after-expected.txt patching file LayoutTests/platform/ios/fast/writing-mode/border-styles-vertical-lr-expected.txt patching file LayoutTests/platform/ios/fast/writing-mode/english-bt-text-expected.txt patching file LayoutTests/platform/ios/tables/mozilla_expected_failures/bugs/bug56024-expected.txt patching file LayoutTests/platform/mac/fast/text/international/bidi-layout-across-linebreak-expected.txt patching file LayoutTests/platform/mac/fast/text/svg-font-face-with-kerning-expected.txt patching file LayoutTests/platform/mac/fast/writing-mode/border-styles-vertical-lr-expected.txt patching file LayoutTests/platform/mac/fast/writing-mode/english-bt-text-expected.txt patching file LayoutTests/platform/mac/fast/writing-mode/text-orientation-basic-expected.txt patching file LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug56024-expected.txt patching file LayoutTests/platform/win/fast/text/international/bidi-layout-across-linebreak-expected.txt patching file LayoutTests/platform/win/fast/writing-mode/english-bt-text-expected.txt patching file LayoutTests/platform/win/fast/writing-mode/text-orientation-basic-expected.txt patching file LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug56024-expected.txt patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/InlineBox.cpp patching file Source/WebCore/rendering/RenderLineBreak.cpp patching file Source/WebCore/rendering/RenderLineBreak.h patching file Source/WebCore/rendering/RenderTreeAsText.cpp patching file Source/WebCore/rendering/SimpleLineLayoutResolver.cpp patching file Source/WebCore/rendering/SimpleLineLayoutResolver.h patching file Source/WebCore/rendering/line/LineLayoutTraversal.h patching file Source/WebCore/rendering/line/LineLayoutTraversalComplexPath.h patching file Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h Hunk #1 FAILED at 58. 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h.rej patching file Source/WebCore/rendering/line/LineLayoutTraversalSimplePath.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Zalan Bujtas']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 44a08ff1186..f9d4af573b1 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 253323 = 44a08ff11860afed0a012f1eb0eab16bcd5e5ced r253324 = f9d4af573b161408b88692aa1619d2b3c3b1ed48 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/13289105
Created attachment 385262 [details] patch
Comment on attachment 385262 [details] patch Clearing flags on attachment: 385262 Committed r253326: <https://trac.webkit.org/changeset/253326>
All reviewed patches have been landed. Closing bug.
<rdar://problem/57795359>