Bug 56024 - Web Inspector: it should be possible to copy stack trace from call stack sidebar pane
Summary: Web Inspector: it should be possible to copy stack trace from call stack side...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-09 09:57 PST by Pavel Podivilov
Modified: 2011-03-09 11:22 PST (History)
10 users (show)

See Also:


Attachments
Patch. (2.87 KB, patch)
2011-03-09 09:58 PST, Pavel Podivilov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-03-09 09:57:31 PST
Web Inspector: it should be possible to copy stack trace from call stack sidebar pane.
Comment 1 Pavel Podivilov 2011-03-09 09:58:06 PST
Created attachment 85187 [details]
Patch.
Comment 2 Pavel Podivilov 2011-03-09 10:02:00 PST
Sample clipboard:

1. createMenu() at committers-autocomplete.js:275
2. enableAutoComplete() at committers-autocomplete.js:373
3. WebKitCommitters.getCommitters.m_committers() at committers-autocomplete.js:390
4. showEditableField() at field.js:188
5. addListener.O() at yahoo-dom-event.js:8
Comment 3 Pavel Feldman 2011-03-09 10:18:04 PST
Comment on attachment 85187 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=85187&action=review

> Source/WebCore/inspector/front-end/CallStackSidebarPane.js:85
> +            this._text += WebInspector.UIString("%i. %s() at %s", i + 1, title, subtitle) + "\n";

I am not sure we need numbers. Do Xcode and VS produce those?
Comment 4 Pavel Podivilov 2011-03-09 10:57:28 PST
(In reply to comment #3)
> (From update of attachment 85187 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85187&action=review
> 
> > Source/WebCore/inspector/front-end/CallStackSidebarPane.js:85
> > +            this._text += WebInspector.UIString("%i. %s() at %s", i + 1, title, subtitle) + "\n";
> 
> I am not sure we need numbers. Do Xcode and VS produce those?

XCode: "#n ..." where n is zero based frame number counting from the top
VS: no numbers
Eclipse: "n ..." where n is one based frame number counting from the bottom
Comment 5 Pavel Podivilov 2011-03-09 11:22:15 PST
Committed r80655: <http://trac.webkit.org/changeset/80655>