inspector/page/overrideSetting-MockCaptureDevicesEnabled.html is failing after removal of internals.setMockMediaCaptureDevicesEnabled API
Created attachment 384807 [details] Patch
Comment on attachment 384807 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384807&action=review > LayoutTests/inspector/page/overrideSetting-MockCaptureDevicesEnabled.html:10 > +// if (window.testRunner && testRunner.isMockRealtimeMediaSourceCenterEnabled && testRunner.isMockRealtimeMediaSourceCenterEnabled() !== expectToUseMock) > +// return "FAIL: testRunner mismatch"; Did you mean to leave these commented out?
True, will fix it!
Created attachment 384816 [details] Patch
Comment on attachment 384816 [details] Patch Rejecting attachment 384816 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 384816, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13286880
Created attachment 384902 [details] Patch for landing
Comment on attachment 384902 [details] Patch for landing Clearing flags on attachment: 384902 Committed r253149: <https://trac.webkit.org/changeset/253149>
All reviewed patches have been landed. Closing bug.
<rdar://problem/57663267>