Bug 204849 - inspector/page/overrideSetting-MockCaptureDevicesEnabled.html is failing after removal of internals.setMockMediaCaptureDevicesEnabled API
Summary: inspector/page/overrideSetting-MockCaptureDevicesEnabled.html is failing afte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-04 07:21 PST by youenn fablet
Modified: 2019-12-05 07:25 PST (History)
9 users (show)

See Also:


Attachments
Patch (20.45 KB, patch)
2019-12-04 07:24 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (22.20 KB, patch)
2019-12-04 09:06 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (21.94 KB, patch)
2019-12-05 06:40 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-12-04 07:21:53 PST
inspector/page/overrideSetting-MockCaptureDevicesEnabled.html is failing after removal of internals.setMockMediaCaptureDevicesEnabled API
Comment 1 youenn fablet 2019-12-04 07:24:38 PST
Created attachment 384807 [details]
Patch
Comment 2 Eric Carlson 2019-12-04 08:50:37 PST
Comment on attachment 384807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384807&action=review

> LayoutTests/inspector/page/overrideSetting-MockCaptureDevicesEnabled.html:10
> +//    if (window.testRunner && testRunner.isMockRealtimeMediaSourceCenterEnabled && testRunner.isMockRealtimeMediaSourceCenterEnabled() !== expectToUseMock)
> +//        return "FAIL: testRunner mismatch";

Did you mean to leave these commented out?
Comment 3 youenn fablet 2019-12-04 09:05:38 PST
True, will fix it!
Comment 4 youenn fablet 2019-12-04 09:06:29 PST
Created attachment 384816 [details]
Patch
Comment 5 WebKit Commit Bot 2019-12-05 05:40:42 PST
Comment on attachment 384816 [details]
Patch

Rejecting attachment 384816 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 384816, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/13286880
Comment 6 youenn fablet 2019-12-05 06:40:25 PST
Created attachment 384902 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-12-05 07:24:21 PST
Comment on attachment 384902 [details]
Patch for landing

Clearing flags on attachment: 384902

Committed r253149: <https://trac.webkit.org/changeset/253149>
Comment 8 WebKit Commit Bot 2019-12-05 07:24:22 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-12-05 07:25:20 PST
<rdar://problem/57663267>