Bug 204512 – [Cocoa] Run camera capture in UIProcess by default in layout tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Move camera capture to UIProcess by default

[youenn fablet]

Created attachment 384147 [details]
Patch

[youenn fablet]

Three tests are failing:
- fast/mediastream/mediastreamtrack-video-clone.html: we need to handle video source resizing correctly when cloned if source is captured in UIProcess.
- webrtc/video-rotation.html: our internals API does not work to simulate rotation in UIProcess, we also need to handle orientation monitoring in UIProcess capture side. 
- fast/mediastream/mock-media-source.html: this test is only disabling mock capture in web process but is keeping mock capture in UIProcess. We cannot currently run tests with real capture devices on. We should update the test and remove the internals API.

[youenn fablet]

Created attachment 384620 [details]
Patch

[Eric Carlson]

Comment on attachment 384620 [details]
Patch

r=me once the iOS-WK2 bot is happy

[youenn fablet]

I forgot to update hasSameInitializationOptions, will fix it.

[youenn fablet]

Created attachment 384633 [details]
Patch for landing

[youenn fablet]

Created attachment 384696 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 384696 [details]
Patch for landing

Clearing flags on attachment: 384696

Committed r253033: <https://trac.webkit.org/changeset/253033>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57586831>

[Truitt Savell]

It looks like the changes in https://trac.webkit.org/changeset/253033/webkit

broke inspector/page/overrideSetting-MockCaptureDevicesEnabled.html

History:
https://results.webkit.org/?suite=layout-tests&test=inspector%2Fpage%2FoverrideSetting-MockCaptureDevicesEnabled.html

Diff:
--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/inspector/page/overrideSetting-MockCaptureDevicesEnabled-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/inspector/page/overrideSetting-MockCaptureDevicesEnabled-actual.txt
@@ -1,11 +1,4 @@
+ALERT: Uncaught exception in test page: TypeError: window.internals.setMockMediaCaptureDevicesEnabled is not a function. (In 'window.internals.setMockMediaCaptureDevicesEnabled(false)', 'window.internals.setMockMediaCaptureDevicesEnabled' is undefined) [file:///Volumes/Data/slave/mojave-release-tests-wk2/build/LayoutTests/inspector/page/overrideSetting-MockCaptureDevicesEnabled.html:8]
+CONSOLE MESSAGE: line 8: TypeError: window.internals.setMockMediaCaptureDevicesEnabled is not a function. (In 'window.internals.setMockMediaCaptureDevicesEnabled(false)', 'window.internals.setMockMediaCaptureDevicesEnabled' is undefined)
+CONSOLE MESSAGE: line 168: TypeError: null is not an object (evaluating 'document.body.appendChild')
 Tests for the Page.overrideSetting command.
-
-
-== Running test suite: Page.overrideSetting
--- Running test case: Page.overrideSetting.MockCaptureDevicesEnabled
-Expected Error: The I/O read operation failed.
-Overriding MockCaptureDevicesEnabled to true...
-PASS: getUserMedia should not fail when no devices are available
-Removing MockCaptureDevicesEnabled override...
-Expected Error: The I/O read operation failed.
-

[youenn fablet]

> Diff:
> ---
> /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/
> inspector/page/overrideSetting-MockCaptureDevicesEnabled-expected.txt
> +++
> /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/
> inspector/page/overrideSetting-MockCaptureDevicesEnabled-actual.txt
> @@ -1,11 +1,4 @@
> +ALERT: Uncaught exception in test page: TypeError:
> window.internals.setMockMediaCaptureDevicesEnabled is not a function. (In
> 'window.internals.setMockMediaCaptureDevicesEnabled(false)',
> 'window.internals.setMockMediaCaptureDevicesEnabled' is undefined)
> [file:///Volumes/Data/slave/mojave-release-tests-wk2/build/LayoutTests/
> inspector/page/overrideSetting-MockCaptureDevicesEnabled.html:8]
> +CONSOLE MESSAGE: line 8: TypeError:
> window.internals.setMockMediaCaptureDevicesEnabled is not a function. (In
> 'window.internals.setMockMediaCaptureDevicesEnabled(false)',
> 'window.internals.setMockMediaCaptureDevicesEnabled' is undefined)

We need to update the test or even remove it as we removed that internals API.

[youenn fablet]

> We need to update the test or even remove it as we removed that internals
> API.

Fix at bug 204849.