Bug 204793 - Mark some WPT test folders as DumpJSConsoleLogInStdErr
Summary: Mark some WPT test folders as DumpJSConsoleLogInStdErr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-03 06:16 PST by youenn fablet
Modified: 2023-05-11 01:36 PDT (History)
7 users (show)

See Also:

Attachments
Patch (352.06 KB, patch)
2019-12-03 07:59 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (387.16 KB, patch)
2019-12-06 07:56 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (391.29 KB, patch)
2019-12-09 01:57 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-12-03 06:16:50 PST 
Mark some WPT test folders as DumpJSConsoleLogInStdErr
Comment 1 youenn fablet 2019-12-03 07:59:40 PST 
Created attachment 384713 [details]
Patch
Comment 2 Fujii Hironori 2019-12-04 00:16:57 PST 
Comment on attachment 384713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384713&action=review

> Tools/ChangeLog:9
> +        This is easier done there instead of TestExpectations as TestExpectations can be overriden in more specific expectations. 

DumpJSConsoleLogInStdErr expectation is considered a bad idea by some developers. (Bug 194586 Comment 3)
And, I removed DumpJSConsoleLogInStdErr expectations from non-imported tests in Bug 194586.
Can you remove DumpJSConsoleLogInStdErr expectation entirely?

> Tools/DumpRenderTree/TestOptions.cpp:47
> +    return path.contains(substring); // Case-insensitive.

The comment mismathces the implementation.
Case-insensitive → Case-sensitive
Tools/WebKitTestRunner/TestOptions.cpp also should be fixed.
Comment 3 youenn fablet 2019-12-06 07:56:33 PST 
Created attachment 385013 [details]
Patch
Comment 4 youenn fablet 2019-12-09 01:57:06 PST 
Created attachment 385139 [details]
Patch
Comment 5 youenn fablet 2019-12-10 09:58:45 PST 
> Can you remove DumpJSConsoleLogInStdErr expectation entirely?

I'd like to skip all stderr from all WPT but there is not consensus yet on that.
Note that having DumpJS as a TestExpectation adds some flexibility.
Comment 6 WebKit Commit Bot 2019-12-10 10:51:17 PST 
Comment on attachment 385139 [details]
Patch

Clearing flags on attachment: 385139

Committed r253331: <https://trac.webkit.org/changeset/253331>
Comment 7 WebKit Commit Bot 2019-12-10 10:51:19 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-12-10 10:52:57 PST 
<rdar://problem/57799760>