Bug 194586 - Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
Summary: Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on: 194587
Blocks:
  Show dependency treegraph
 
Reported: 2019-02-13 00:20 PST by Fujii Hironori
Modified: 2019-02-17 18:25 PST (History)
11 users (show)

See Also:


Attachments
Patch (15.05 KB, patch)
2019-02-13 02:36 PST, Fujii Hironori
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews204 for win-future (12.84 MB, application/zip)
2019-02-13 04:22 PST, Build Bot
no flags Details
Patch (16.85 KB, patch)
2019-02-13 18:16 PST, Fujii Hironori
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews204 for win-future (12.86 MB, application/zip)
2019-02-13 21:47 PST, Build Bot
no flags Details
Patch (17.93 KB, patch)
2019-02-13 23:31 PST, Fujii Hironori
ross.kirsling: review+
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (13.73 MB, application/zip)
2019-02-14 01:36 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-02-13 00:20:48 PST
Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations

See Bug 194283.
Comment 1 Claudio Saavedra 2019-02-13 00:44:54 PST
I see your patch in bug 194283 already does this. What else do you need?
Comment 2 Claudio Saavedra 2019-02-13 00:45:14 PST
(In reply to Claudio Saavedra from comment #1)
> I see your patch in bug 194283 already does this. What else do you need?

Arg, wrong bug. Ignore this.
Comment 3 Fujii Hironori 2019-02-13 02:19:46 PST
DumpJSConsoleLogInStdErr expectation is considered a bad idea by some developers.
And, we have dumpJSConsoleLogInStdErr test option now (Bug 177027).
So, I'd like to remove DumpJSConsoleLogInStdErr expectation and use dumpJSConsoleLogInStdErr test option instead.

(In reply to Jonathan Bedard from bug #194283 comment #3)
> This bug very much confuses me. Why would we have a test expectation with
> DumpJSConsoleLogInStdErr in it? That feels like an abuse of the
> TestExpectations.

(In reply to Alexey Proskuryakov from bug #194283 comment #2)
> I think that we are hitting a design mistake with regards to
> DumpJSConsoleLogInStdErr - it is not an expectation, so mixing it with
> expectations causes trouble.

(In reply to youenn fablet from bug #161310 comment #4)
> It seems a bit odd to add that keyword to TestExpectations since it is
> becoming more like a setup option. This applies also a bit to Slow keyword.
Comment 4 Fujii Hironori 2019-02-13 02:36:39 PST
Created attachment 361905 [details]
Patch
Comment 5 Build Bot 2019-02-13 04:22:00 PST
Comment on attachment 361905 [details]
Patch

Attachment 361905 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11133612

New failing tests:
http/tests/security/frame-loading-via-document-write.html
http/tests/security/cross-origin-cached-images-parallel.html
http/tests/security/frame-loading-via-document-write-async-delegates.html
Comment 6 Build Bot 2019-02-13 04:22:12 PST
Created attachment 361911 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment 7 Fujii Hironori 2019-02-13 18:16:06 PST
Created attachment 361979 [details]
Patch
Comment 8 Build Bot 2019-02-13 21:47:19 PST
Comment on attachment 361979 [details]
Patch

Attachment 361979 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11142759

New failing tests:
http/tests/security/frame-loading-via-document-write.html
http/tests/security/cross-origin-cached-images-parallel.html
http/tests/security/frame-loading-via-document-write-async-delegates.html
Comment 9 Build Bot 2019-02-13 21:47:30 PST
Created attachment 361995 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment 10 Fujii Hironori 2019-02-13 22:43:47 PST
Win DumpRenderTree is failing to get webkit-test-runner magic comment if run-webkit-tests is running by Cygwin Python.
Comment 11 Fujii Hironori 2019-02-13 23:31:50 PST
Created attachment 361997 [details]
Patch
Comment 12 Build Bot 2019-02-14 01:36:26 PST Comment hidden (obsolete)
Comment 13 Build Bot 2019-02-14 01:36:28 PST Comment hidden (obsolete)
Comment 14 Fujii Hironori 2019-02-17 18:24:12 PST
Landed: https://trac.webkit.org/r241656
Comment 15 Radar WebKit Bug Importer 2019-02-17 18:25:49 PST
<rdar://problem/48151478>