Bug 204701 - Use default implementation for JSVALUE64 with GCC on unknown platform.
Summary: Use default implementation for JSVALUE64 with GCC on unknown platform.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 204643 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-11-29 06:54 PST by Eike Rathke
Modified: 2019-12-01 10:18 PST (History)
9 users (show)

See Also:


Attachments
Patch (3.19 KB, patch)
2019-11-29 06:57 PST, Eike Rathke
no flags Details | Formatted Diff | Diff
Patch (2.54 KB, patch)
2019-11-29 07:02 PST, Eike Rathke
no flags Details | Formatted Diff | Diff
Patch (1.95 KB, patch)
2019-11-29 07:08 PST, Eike Rathke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Rathke 2019-11-29 06:54:00 PST
Use default implementation for JSVALUE64 with GCC on unknown platform.
Comment 1 Eike Rathke 2019-11-29 06:57:01 PST
Created attachment 384504 [details]
Patch
Comment 2 Eike Rathke 2019-11-29 07:02:43 PST
Created attachment 384505 [details]
Patch
Comment 3 Eike Rathke 2019-11-29 07:06:19 PST
Grml.. webkit-patch insists on including it's on modification to force python2 even if already committed. I'll resubmit a manual patch.
Comment 4 Eike Rathke 2019-11-29 07:08:58 PST
Created attachment 384506 [details]
Patch
Comment 5 Eike Rathke 2019-11-29 07:35:31 PST
Note: the style checker seems to be wrong in its analysis.
Comment 6 Saam Barati 2019-11-29 10:13:37 PST
Comment on attachment 384506 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2019-11-29 11:03:42 PST
Comment on attachment 384506 [details]
Patch

Clearing flags on attachment: 384506

Committed r252949: <https://trac.webkit.org/changeset/252949>
Comment 8 WebKit Commit Bot 2019-11-29 11:03:44 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-11-29 11:04:19 PST
<rdar://problem/57534280>
Comment 10 Alberto Garcia 2019-12-01 10:18:49 PST
*** Bug 204643 has been marked as a duplicate of this bug. ***