Bug 20437 - Clean XMLTokenizer by separating the Qt and Libxml2 implementation
Summary: Clean XMLTokenizer by separating the Qt and Libxml2 implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 14791 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-08-18 16:40 PDT by Holger Freyther
Modified: 2009-11-21 01:27 PST (History)
1 user (show)

See Also:

Attachments
Start separating XMLTokenizer (132.82 KB, patch)
2008-08-18 17:04 PDT, Holger Freyther 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Freyther 2008-08-18 16:40:29 PDT 
The current XMLTokenizer.cpp is hard to read as two separate implementations are in one file. Separating the Qt and libxml2 implementation should make it more readable.
Comment 1 Holger Freyther 2008-08-18 17:04:56 PDT 
Created attachment 22867 [details]
Start separating XMLTokenizer

Keep common code in XMLTokenizer.cpp, move Qt code to XMLTokenizerQt.cpp and the rest to XMLTokenizerLibxml2.cpp.
Comments appreciated.
Comment 2 Mark Rowe (bdash) 2008-08-18 19:10:42 PDT 
It might be a good idea to create the two new .cpp files by doing an "svn cp" of XMLTokenizer.cpp then removing the unneeded bits.  That would help make it obvious what has happened in the SVN history.
Comment 3 Mark Rowe (bdash) 2008-08-19 20:52:35 PDT 
Should also change USE_QXMLSTREAM to the USE(QXMLSTREAM) style that we use for these sorts of things elsewhere.
Comment 4 Mark Rowe (bdash) 2008-08-19 22:24:44 PDT 
Oh, and the new file will need to be added to the Mac, Windows and Wx project files too.
Comment 5 Mark Rowe (bdash) 2008-08-19 22:25:37 PDT 
Comment on attachment 22867 [details]
Start separating XMLTokenizer

r=me, if you address the comments I made above, and add a ChangeLog entry.
Comment 6 Holger Freyther 2008-09-18 17:18:54 PDT 
I think I addressed all the points and landed this patch. The size of the patch is a bit worrying but it looked good.
Comment 7 Simon Hausmann 2009-11-21 01:27:00 PST 
*** Bug 14791 has been marked as a duplicate of this bug. ***