RESOLVED DUPLICATE of bug 20437 14791
Separate Qt and libxml based implementations of XMLTokenizer
https://bugs.webkit.org/show_bug.cgi?id=14791
Summary Separate Qt and libxml based implementations of XMLTokenizer
Lars Knoll
Reported 2007-07-27 14:06:14 PDT
The attached patch separates the Qt and libxml based implementations of XMLTokenizer into separate files while keeping the common code in XMLTokenizer.cpp
Attachments
Patch to separate both XMLTokenizer implementations. (111.74 KB, patch)
2007-07-27 14:08 PDT, Lars Knoll
eric: review-
Lars Knoll
Comment 1 2007-07-27 14:08:13 PDT
Created attachment 15708 [details] Patch to separate both XMLTokenizer implementations.
Darin Adler
Comment 2 2007-08-11 15:43:13 PDT
Sorry I haven't reviewed this yet. I know I'm the one who asked for it! I'll get to it ASAP (unless someone else reviews it first).
Lars Knoll
Comment 3 2007-08-12 00:42:38 PDT
No problem. The patch does not fix the fix the build system for the Safari builds btw (as I didn't have a Mac at hand). I was hoping you could add these pieces :)
Eric Seidel (no email)
Comment 4 2007-09-29 12:51:19 PDT
FYI, this patch will conflict with the one attached to bug 15302 (mathml bug, also up for review)
Eric Seidel (no email)
Comment 5 2007-09-30 12:08:26 PDT
Lars, I think we should just chat about this on irc. I've done lots of these types of splits -- they're easy to do, but they tend to go stale as patches *very quickly*. If you grab me (or any other reviewer) on irc, it would be real quick to just re-do this patch from scratch and get it reviewed immediately. I'd be happy to assist in that if I'm around.
Eric Seidel (no email)
Comment 6 2007-10-03 09:48:35 PDT
Comment on attachment 15708 [details] Patch to separate both XMLTokenizer implementations. This should be re-done and reviewed immediately. I'm certain this patch has rotten by now. :(
Simon Hausmann
Comment 7 2009-11-21 01:27:00 PST
*** This bug has been marked as a duplicate of bug 20437 ***
Note You need to log in before you can comment on or make changes to this bug.